D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-23 Thread Nathaniel Graham
ngraham added a comment.


  All right, how about this?
  
  F5763759: Better 2.png 
  
  F5763758: better.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-23 Thread Nathaniel Graham
ngraham updated this revision to Diff 30327.
ngraham added a comment.


  Use a more appropriate icon and shorten the string

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11253?vs=30313&id=30327

BRANCH
  arcpatch-D11253

REVISION DETAIL
  https://phabricator.kde.org/D11253

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-23 Thread David Edmundson
davidedmundson added a comment.


  There's a pre-existing discussion on bugzilla about the latter comment.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-23 Thread Marco Martin
mart added a comment.


  In D11253#232219 , @richardbowen 
wrote:
  
  > Also how about a preferences shortcut for "Desktop Wallpaper" (or some 
other suitable text) searchable from the start menu and krunner? This would be 
similar to the other desktop preferences that are searchable like "Desktop 
Theme", "Desktop Effects", etc..
  >
  > F5763672: Screenshot_20180323_085008.png 
 F5763671: Screenshot_20180323_085252.png 

  
  
  from an ui pov makes sense, tough may not be super easy as wallpaper config 
is not a kcm.. perhaps a dbus methos exposed by plasmashell

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-23 Thread Richard Bowen
richardbowen added a comment.


  Also how about a preferences shortcut for "Desktop Wallpaper" (or some other 
suitable text) searchable from the start menu and krunner? This would be 
similar to the other desktop preferences that are searchable like "Desktop 
Theme", "Desktop Effects", etc..
  
  F5763672: Screenshot_20180323_085008.png 
 F5763671: Screenshot_20180323_085252.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-23 Thread Nathaniel Graham
ngraham updated this revision to Diff 30313.
ngraham added a comment.


  Rebase on master, it's been a while

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11253?vs=29300&id=30313

BRANCH
  arcpatch-D11253

REVISION DETAIL
  https://phabricator.kde.org/D11253

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-23 Thread Richard Bowen
richardbowen added a comment.


  In D11253#232189 , @mart wrote:
  
  > what about as text using Configure-desktop and as icon 
preferences-desktop-wallpaper?F5763655: Spectacle.T27450.png 

  
  
  +1
  
  A big part of the desktop experience is the wallpaper so this looks good. 
Also the wallpaper setting is the first option in the "Configure Desktop" 
window so having this as the wallpaper icon beside "Configure Desktop" gives a 
good hint that setting the wallpaper is a function of Configure Desktop.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-23 Thread Marco Martin
mart added a comment.


  what about as text using Configure-desktop and as icon 
preferences-desktop-wallpaper?F5763655: Spectacle.T27450.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-13 Thread Nathaniel Graham
ngraham added a comment.


  So what's our path forward here? We have some positive votes and some 
negative votes. Do we need to first have a wider conversation on wallpaper 
discoverability and then later circle back to something we can all agree on?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-13 Thread Kai Uwe Broulik
broulik added a comment.


  >   "plz keep this as short as pssible bcause is a context menu"
  
  Widget apps use `i18nc("@action:inmenu", "...")`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-13 Thread Marco Martin
mart added a comment.


  In D11253#223766 , @broulik wrote:
  
  > +1
  >
  > I just hope it won't make the menu too wide „Arbeitsfläche und 
Hintergrundbild einrichten“ is what I guess it would be for my locale (but then 
we already have „Inhalt der Zwischenablage einfügen“ for Paste) so that is not 
a big deal ;)
  
  
  maybe an i18nc in which in the context one says "plz keep this as short as 
pssible bcause is a context menu"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-12 Thread Nathaniel Graham
ngraham added a comment.


  In D11253#223776 , @hein wrote:
  
  > This patch is based on misunderstanding a reddit comment: 
https://bugs.kde.org/show_bug.cgi?id=391485#c9
  >
  > Heavy -1 for making the menu way too wordy.
  >
  > On a meta-level, it's also really bad form to argue for patches with 
anecdotal internet comments, even if they haven't been misunderstood in the 
first place. We really don't need the drama.
  
  
  Even if I misunderstood the comment (oops), shouldn't we listen to our users? 
This patch wasn't based entirely on that single comment; rather, it was an 
example of a pattern I've noticed over time: that our users have difficulty 
finding how to change the wallpaper. That impression comes predominately from 
online interactions with actual users. It's hard for me to see how that would 
be invalid, in the aggregate.
  
  If this isn't the right approach, I can accept that, but I believe that we 
need to do //something// for wallpaper configuration discoverability. I'm open 
to ideas.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-12 Thread Eike Hein
hein added a comment.


  This patch is based on misunderstanding a reddit comment: 
https://bugs.kde.org/show_bug.cgi?id=391485#c9
  
  -1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: hein, broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-12 Thread Kai Uwe Broulik
broulik added a comment.


  +1
  
  I just hope it won't make the menu too wide „Arbeitsfläche und 
Hintergrundbild einrichten“ is what I guess it would be for my locale (but then 
we already have „Inhalt der Zwischenablage einfügen“ for Paste) so that is not 
a big deal ;)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: broulik, richardbowen, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-11 Thread Richard Bowen
richardbowen added a comment.


  I wonder if one should dumb down the interface to accommodate this word 
scanning habit, where one doesn't really read stuff one just scans the screen 
for a keyword and then gets frustrated when the keyword (like "Wallpaper") 
doesn't show up . Well if it works then fine. The proposed text is quite long 
though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: richardbowen, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-11 Thread Nathaniel Graham
ngraham added a comment.


  In D11253#223747 , @richardbowen 
wrote:
  
  > Windows has the word "Personalize" which is quite descriptive. "Customize 
Desktop" sounds fine as well. but I think the word "Configure" is used more 
often throughtout the Plasma desktop.
  >
  > How often do you see users complaining about not knowing how to set the 
wallpaper?
  
  
  Often. Here's an example I just stumbled upon tonight: 
https://www.reddit.com/r/gnome/comments/8360xr/gnome_is_design/dvh9reu/
  
  > They also throw so many functionalities at your face, but basic things like 
right-click and set as wallpaper is not there. Kde was built by developers for 
developers.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: richardbowen, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-11 Thread Richard Bowen
richardbowen added a comment.


  Windows has the word "Personalize" which is quite descriptive. "Customize 
Desktop" sounds fine as well. but I think the word "Configure" is used more 
often throughtout the Plasma desktop.
  
  How often do you see users complaining about not knowing how to set the 
wallpaper? If they know what a desktop is then they should be able to figure it 
out. Similar to Windows it is accessed via a right click context menu.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: richardbowen, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D11253: Add the word "Wallpaper" into the context and Toolbox menus to help users figure out how to change the wallpaper

2018-03-11 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  It comes up a lot online that users have difficulty figuring out how to 
change the wallpaper. Yes, really! I'm serious! This baffles people like us 
because there's a totally simple way: right-click on the Desktop or left-click 
on the Desktop Toolbox and choose "Configure Desktop". However since that menu 
item doesn't have the word "Wallpaper" in it, a lot of users never seem to make 
the mental leap that Wallpapers are associated with the Desktop, and instead 
conclude that there's no way to change the wallpaper, since they can't find it 
in System Settings, either.
  
  This patch updates the menu item to add the word "Wallpaper", making the 
presence of the feature hugely more obvious.
  
  CCBUG: 391485

TEST PLAN
  Now more obvious in the Desktop Toolbox menu:
  
  Now more obvious in the context menu:

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-the-word-wallpaper-so-people-actually-get-it (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11253

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

To: ngraham, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart