D11563: Remove long-time deprecated Encoding=UTF-8 from desktop format files
This revision was automatically updated to reflect the committed changes. Closed by commit R120:45a19fa16c45: Remove long-time deprecated Encoding=UTF-8 from desktop format files (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11563?vs=30164&id=30338 REVISION DETAIL https://phabricator.kde.org/D11563 AFFECTED FILES applets/appmenu/package/metadata.desktop applets/batterymonitor/package/metadata.desktop applets/calendar/package/metadata.desktop applets/digital-clock/package/metadata.desktop applets/lock_logout/metadata.desktop applets/mediacontroller/metadata.desktop applets/notifications/package/metadata.desktop applets/systemmonitor/cpu/metadata.desktop applets/systemmonitor/diskactivity/metadata.desktop applets/systemmonitor/diskusage/metadata.desktop applets/systemmonitor/memory/metadata.desktop applets/systemmonitor/net/metadata.desktop applets/systemtray/container/package/metadata.desktop applets/systemtray/package/metadata.desktop dataengines/executable/plasma-dataengine-executable.desktop dataengines/favicons/plasma-dataengine-favicons.desktop dataengines/geolocation/plasma-dataengine-geolocation.desktop dataengines/network/plasma-dataengine-network.desktop dataengines/packagekit/plasma-dataengine-packagekit.desktop dataengines/rss/plasma-dataengine-rss.desktop dataengines/systemmonitor/plasma-dataengine-systemmonitor.desktop kioslave/desktop/Home.desktop kioslave/desktop/directory.desktop kioslave/desktop/directory.trash lookandfeel/metadata.desktop menu/desktop/hidden.directory menu/desktop/kf5-development-translation.directory menu/desktop/kf5-development-webdevelopment.directory menu/desktop/kf5-development.directory menu/desktop/kf5-editors.directory menu/desktop/kf5-edu-languages.directory menu/desktop/kf5-edu-mathematics.directory menu/desktop/kf5-edu-miscellaneous.directory menu/desktop/kf5-edu-science.directory menu/desktop/kf5-edu-tools.directory menu/desktop/kf5-education.directory menu/desktop/kf5-games-arcade.directory menu/desktop/kf5-games-board.directory menu/desktop/kf5-games-card.directory menu/desktop/kf5-games-kids.directory menu/desktop/kf5-games-logic.directory menu/desktop/kf5-games-roguelikes.directory menu/desktop/kf5-games-strategy.directory menu/desktop/kf5-games.directory menu/desktop/kf5-graphics.directory menu/desktop/kf5-internet-terminal.directory menu/desktop/kf5-internet.directory menu/desktop/kf5-main.directory menu/desktop/kf5-more.directory menu/desktop/kf5-multimedia.directory menu/desktop/kf5-office.directory menu/desktop/kf5-science.directory menu/desktop/kf5-settingsmenu.directory menu/desktop/kf5-system-terminal.directory menu/desktop/kf5-system.directory menu/desktop/kf5-toys.directory menu/desktop/kf5-unknown.directory menu/desktop/kf5-utilities-accessibility.directory menu/desktop/kf5-utilities-desktop.directory menu/desktop/kf5-utilities-file.directory menu/desktop/kf5-utilities-peripherals.directory menu/desktop/kf5-utilities-pim.directory menu/desktop/kf5-utilities-xutils.directory menu/desktop/kf5-utilities.directory plasma.desktop.cmake plasmawayland.desktop.cmake wallpapers/color/metadata.desktop wallpapers/image/imagepackage/metadata.desktop wallpapers/image/slideshowpackage/metadata.desktop To: kossebau, #plasma, fvogt, broulik, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11563: Remove long-time deprecated Encoding=UTF-8 from desktop format files
kossebau added a comment. Based on request on irc # plasma yesterday: [14:34] frinring: Feel free to remove it again - in all branches please If okayed, would do the same in the Plasma/5.12 branch to all other plasma repos I touched before in master only for this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11563 To: kossebau, #plasma, fvogt, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11563: Remove long-time deprecated Encoding=UTF-8 from desktop format files
kossebau updated this revision to Diff 30164. kossebau added a comment. remove unrelated fields.txt file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11563?vs=30163&id=30164 BRANCH removeencoding REVISION DETAIL https://phabricator.kde.org/D11563 AFFECTED FILES applets/appmenu/package/metadata.desktop applets/batterymonitor/package/metadata.desktop applets/calendar/package/metadata.desktop applets/digital-clock/package/metadata.desktop applets/lock_logout/metadata.desktop applets/mediacontroller/metadata.desktop applets/notifications/package/metadata.desktop applets/systemmonitor/cpu/metadata.desktop applets/systemmonitor/diskactivity/metadata.desktop applets/systemmonitor/diskusage/metadata.desktop applets/systemmonitor/memory/metadata.desktop applets/systemmonitor/net/metadata.desktop applets/systemtray/container/package/metadata.desktop applets/systemtray/package/metadata.desktop dataengines/executable/plasma-dataengine-executable.desktop dataengines/favicons/plasma-dataengine-favicons.desktop dataengines/geolocation/plasma-dataengine-geolocation.desktop dataengines/network/plasma-dataengine-network.desktop dataengines/packagekit/plasma-dataengine-packagekit.desktop dataengines/rss/plasma-dataengine-rss.desktop dataengines/systemmonitor/plasma-dataengine-systemmonitor.desktop kioslave/desktop/Home.desktop kioslave/desktop/directory.desktop kioslave/desktop/directory.trash lookandfeel/metadata.desktop menu/desktop/hidden.directory menu/desktop/kf5-development-translation.directory menu/desktop/kf5-development-webdevelopment.directory menu/desktop/kf5-development.directory menu/desktop/kf5-editors.directory menu/desktop/kf5-edu-languages.directory menu/desktop/kf5-edu-mathematics.directory menu/desktop/kf5-edu-miscellaneous.directory menu/desktop/kf5-edu-science.directory menu/desktop/kf5-edu-tools.directory menu/desktop/kf5-education.directory menu/desktop/kf5-games-arcade.directory menu/desktop/kf5-games-board.directory menu/desktop/kf5-games-card.directory menu/desktop/kf5-games-kids.directory menu/desktop/kf5-games-logic.directory menu/desktop/kf5-games-roguelikes.directory menu/desktop/kf5-games-strategy.directory menu/desktop/kf5-games.directory menu/desktop/kf5-graphics.directory menu/desktop/kf5-internet-terminal.directory menu/desktop/kf5-internet.directory menu/desktop/kf5-main.directory menu/desktop/kf5-more.directory menu/desktop/kf5-multimedia.directory menu/desktop/kf5-office.directory menu/desktop/kf5-science.directory menu/desktop/kf5-settingsmenu.directory menu/desktop/kf5-system-terminal.directory menu/desktop/kf5-system.directory menu/desktop/kf5-toys.directory menu/desktop/kf5-unknown.directory menu/desktop/kf5-utilities-accessibility.directory menu/desktop/kf5-utilities-desktop.directory menu/desktop/kf5-utilities-file.directory menu/desktop/kf5-utilities-peripherals.directory menu/desktop/kf5-utilities-pim.directory menu/desktop/kf5-utilities-xutils.directory menu/desktop/kf5-utilities.directory plasma.desktop.cmake plasmawayland.desktop.cmake wallpapers/color/metadata.desktop wallpapers/image/imagepackage/metadata.desktop wallpapers/image/slideshowpackage/metadata.desktop To: kossebau, #plasma, fvogt, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11563: Remove long-time deprecated Encoding=UTF-8 from desktop format files
kossebau created this revision. kossebau added reviewers: Plasma, fvogt, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The "Encoding" entry had been deprecated in 2006 (https://cgit.freedesktop.org/xdg/xdg-specs/commit/?id=6855384d021d88557f80674798c584c15b547f36) and there is no current workspace known which still requires it being set (incl. Plasma itself). Also has the usage been incomplete and sometimes not at the beginning as required if used (once scripty had sorted all entries in desktop files alphabetically and it was not restored everywhere). Removing them altogether creates consistency and avoids further confusion about and wasted resources for this unused data bit. Removing those entries also from Plasma/5.12 branch avoid conflicts on merging to master, given the entries are often next to translated entries, or generous merging which lets the entries slip back into existance. REPOSITORY R120 Plasma Workspace BRANCH removeencoding REVISION DETAIL https://phabricator.kde.org/D11563 AFFECTED FILES applets/appmenu/package/metadata.desktop applets/batterymonitor/package/metadata.desktop applets/calendar/package/metadata.desktop applets/digital-clock/package/metadata.desktop applets/lock_logout/metadata.desktop applets/mediacontroller/metadata.desktop applets/notifications/package/metadata.desktop applets/systemmonitor/cpu/metadata.desktop applets/systemmonitor/diskactivity/metadata.desktop applets/systemmonitor/diskusage/metadata.desktop applets/systemmonitor/memory/metadata.desktop applets/systemmonitor/net/metadata.desktop applets/systemtray/container/package/metadata.desktop applets/systemtray/package/metadata.desktop dataengines/executable/plasma-dataengine-executable.desktop dataengines/favicons/plasma-dataengine-favicons.desktop dataengines/geolocation/plasma-dataengine-geolocation.desktop dataengines/network/plasma-dataengine-network.desktop dataengines/packagekit/plasma-dataengine-packagekit.desktop dataengines/rss/plasma-dataengine-rss.desktop dataengines/systemmonitor/plasma-dataengine-systemmonitor.desktop dataengines/weather/fields.txt kioslave/desktop/Home.desktop kioslave/desktop/directory.desktop kioslave/desktop/directory.trash lookandfeel/metadata.desktop menu/desktop/hidden.directory menu/desktop/kf5-development-translation.directory menu/desktop/kf5-development-webdevelopment.directory menu/desktop/kf5-development.directory menu/desktop/kf5-editors.directory menu/desktop/kf5-edu-languages.directory menu/desktop/kf5-edu-mathematics.directory menu/desktop/kf5-edu-miscellaneous.directory menu/desktop/kf5-edu-science.directory menu/desktop/kf5-edu-tools.directory menu/desktop/kf5-education.directory menu/desktop/kf5-games-arcade.directory menu/desktop/kf5-games-board.directory menu/desktop/kf5-games-card.directory menu/desktop/kf5-games-kids.directory menu/desktop/kf5-games-logic.directory menu/desktop/kf5-games-roguelikes.directory menu/desktop/kf5-games-strategy.directory menu/desktop/kf5-games.directory menu/desktop/kf5-graphics.directory menu/desktop/kf5-internet-terminal.directory menu/desktop/kf5-internet.directory menu/desktop/kf5-main.directory menu/desktop/kf5-more.directory menu/desktop/kf5-multimedia.directory menu/desktop/kf5-office.directory menu/desktop/kf5-science.directory menu/desktop/kf5-settingsmenu.directory menu/desktop/kf5-system-terminal.directory menu/desktop/kf5-system.directory menu/desktop/kf5-toys.directory menu/desktop/kf5-unknown.directory menu/desktop/kf5-utilities-accessibility.directory menu/desktop/kf5-utilities-desktop.directory menu/desktop/kf5-utilities-file.directory menu/desktop/kf5-utilities-peripherals.directory menu/desktop/kf5-utilities-pim.directory menu/desktop/kf5-utilities-xutils.directory menu/desktop/kf5-utilities.directory plasma.desktop.cmake plasmawayland.desktop.cmake wallpapers/color/metadata.desktop wallpapers/image/imagepackage/metadata.desktop wallpapers/image/slideshowpackage/metadata.desktop To: kossebau, #plasma, fvogt, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
