D11571: [Battery Monitor] Support "Gaming Input Battery type"

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:032fbb83613b: [Battery Monitor] Support Gaming 
Input Battery type (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11571?vs=30197=30694

REVISION DETAIL
  https://phabricator.kde.org/D11571

AFFECTED FILES
  components/workspace/BatteryIcon.qml
  dataengines/powermanagement/powermanagementengine.cpp
  dataengines/soliddevice/soliddeviceengine.cpp

To: broulik, #plasma, dollinger, lbeltrame, davidedmundson
Cc: ngraham, anthonyfieroni, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11571: [Battery Monitor] Support "Gaming Input Battery type"

[Kai Uwe Broulik]

broulik added a comment.


  In D11571#231359 , @anthonyfieroni 
wrote:
  
  > @broulik, does it makes sens, when batteries isn't available (as your 
screenshot) to be shown, the icon and its percentage of next device in the 
list, in systray ?
  
  
  I thought about that a long time and I think we even used to show the lowest 
peripheral battery, if any, but it wasn't particularly predictable what it 
shows, so I removed it. Could be revisited at some point but that is unrelated 
to this patch

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11571

To: broulik, #plasma, dollinger, lbeltrame
Cc: anthonyfieroni, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11571: [Battery Monitor] Support "Gaming Input Battery type"

[Anthony Fieroni]

anthonyfieroni added a comment.


  @broulik, does it makes sens, when batteries isn't available (as your 
screenshot) to be shown, the icon of next device in the list, in systray ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11571

To: broulik, #plasma, dollinger, lbeltrame
Cc: anthonyfieroni, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11571: [Battery Monitor] Support "Gaming Input Battery type"

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt, dollinger.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Gives them a nicer icon.
  The icon does not yet exist in Plasma but `gaming-input` does, so it falls 
back to that.

TEST PLAN
  I think this stuff (sans the soliddeviceengine i18n) could also go into 5.12 
since it's trivial and Frameworks that suddenly supports those devices is 
independent of Plasma
  F5762235: Screenshot_20180322_084502.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11571

AFFECTED FILES
  components/workspace/BatteryIcon.qml
  dataengines/powermanagement/powermanagementengine.cpp
  dataengines/soliddevice/soliddeviceengine.cpp

To: broulik, #plasma, fvogt, dollinger
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart