D11606: [WebBrowser Plasmoid] Support opening external links

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:0319b3e9c96f: [WebBrowser Plasmoid] Support opening 
external links (authored by broulik).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11606?vs=30291&id=30632

REVISION DETAIL
  https://phabricator.kde.org/D11606

AFFECTED FILES
  applets/webbrowser/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: davidedmundson, Murz, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11606: [WebBrowser Plasmoid] Support opening external links

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:65-67
> You can find a better solution. Especially as there's only 3 items (two 
> spaces) in this Layout.

The layout is

  [<] [>] [address bar] [popup blocked] [ reload ]

I want a space between everything except around the popup info

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11606

To: broulik, #plasma, #vdg
Cc: davidedmundson, Murz, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11606: [WebBrowser Plasmoid] Support opening external links

[David Edmundson]

davidedmundson added a comment.


  In general fine.

INLINE COMMENTS

> main.qml:65-67
> +// button itself adds sufficient visual padding
> +Layout.leftMargin: -parent.spacing
> +Layout.rightMargin: -parent.spacing

You can find a better solution. Especially as there's only 3 items (two spaces) 
in this Layout.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11606

To: broulik, #plasma, #vdg
Cc: davidedmundson, Murz, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11606: [WebBrowser Plasmoid] Support opening external links

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This implements a context menu for opening links externally. There is 
unfortunately currently no way to add custom context menu entries to 
`WebEngineView`'s context menu, so the link menu is completely replaced.
  It also lets websites open new windows and fixes `target="_blank"` links
  
  CCBUG: 371023

TEST PLAN
  F5763534: Screenshot_20180323_112038.png 

  Verified that clicking a `` 
link does not result in that file being executed.
  Unwanted popups are successfully blocked and show a hint
  F5763531: Screenshot_20180323_111931.png 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11606

AFFECTED FILES
  applets/webbrowser/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart