D11625: Unify padding on all sides of app icons in delegates
ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11625 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11625: Unify padding on all sides of app icons in delegates
ngraham updated this revision to Diff 30356. ngraham added a comment. Very very slightly increase padding (2 -> 3) in compact mode for better aesthetics REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11625?vs=30354=30356 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11625 AFFECTED FILES discover/qml/ApplicationDelegate.qml To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11625: Unify padding on all sides of app icons in delegates
ngraham updated this revision to Diff 30354. ngraham added a comment. Improve spacing in compact view with this new style REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11625?vs=30353=30354 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11625 AFFECTED FILES discover/qml/ApplicationDelegate.qml To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11625: Unify padding on all sides of app icons in delegates
ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Without this patch, delegate app icons got more padding on the top and bottom than they did on the sides, which was especialyl noticeable with icons that are square or fit into a square. This patch makes sides of the icon get the same padding, improving the presentation. TEST PLAN [images go here] REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D11625 AFFECTED FILES discover/qml/ApplicationDelegate.qml To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
