D11842: Remove categories from app delegates

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:0911fbcd561c: Remove categories from app delegates 
(authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11842?vs=31109&id=31703

REVISION DETAIL
  https://phabricator.kde.org/D11842

AFFECTED FILES
  discover/qml/ApplicationDelegate.qml

To: ngraham, apol, #discover_software_store
Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11842: Remove categories from app delegates

[Nathaniel Graham]

ngraham added a comment.


  Patch to bump the version required: D12035: Bump KF5 version requirement to 
5.45 

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11842

To: ngraham, apol, #discover_software_store
Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11842: Remove categories from app delegates

[Nathaniel Graham]

ngraham added a comment.


  In D11842#241862 , @rkflx wrote:
  
  > FWIW, have a +1 for the idea. Removing the categories is not ideal, but 
having the ratings can be much more enticing for the user to install the app, 
and there is only so much space… Thus I think it's the better compromise to go 
with the ratings.
  >
  >  ---
  >
  > BTW, could not run the patch, because Discover master fails to start for me:
  >
  >   QQmlApplicationEngine failed to load component
  >   qrc:/qml/DiscoverWindow.qml:159 Cannot assign to non-existent property 
"showCloseButton"
  >
  >
  > Any tips? I ran this on a non-master KF5/Plasma desktop, but CMake did not 
complain so it should be fine, right?
  
  
  Yeah, we're depending on a feature in the KF 5.45 version of Kirigami, We 
should mark that dependency.
  
  > One more thing: Lately I'm missing the "before" screenshots in your 
patches, although they would be really helpful! (If you installed to `~/usr` 
instead of `/usr`, for non-unique apps you could even run both versions in 
parallel for all your screenshotting needs, or in sequence for unique apps…)
  
  Sure, I'll try to get back to including before examples too. It's not 
technically challenging, I'm just being lazy. :-)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11842

To: ngraham, apol, #discover_software_store
Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11842: Remove categories from app delegates

[Henrik Fehlauer]

rkflx added a comment.


  FWIW, have a +1 for the idea. Removing the categories is not ideal, but 
having the ratings can be much more enticing for the user to install the app, 
and there is only so much space… Thus I think it's the better compromise to go 
with the ratings.
  
  ---
  
  BTW, could not run the patch, because Discover master fails to start for me:
  
QQmlApplicationEngine failed to load component
qrc:/qml/DiscoverWindow.qml:159 Cannot assign to non-existent property 
"showCloseButton"
  
  Any tips? I ran this on a non-master KF5/Plasma desktop, but CMake did not 
complain so it should be fine, right?
  
  One more thing: Lately I'm missing the "before" screenshots in your patches, 
although they would be really helpful! (If you installed to `~/usr` instead of 
`/usr`, for non-unique apps you could even run both versions in parallel for 
all your screenshotting needs, or in sequence for unique apps…)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D11842

To: ngraham, apol, #discover_software_store
Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11842: Remove categories from app delegates

[Nathaniel Graham]

ngraham updated this revision to Diff 31109.
ngraham added a comment.


  Rebase on master

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11842?vs=31054&id=31109

BRANCH
  remove-categories-on-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11842

AFFECTED FILES
  discover/qml/ApplicationDelegate.qml

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11842: Remove categories from app delegates

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch removes category labels from the app delegates, for the following 
reasons:
  
  - They're not very useful in the first place; the caption generally provides 
all the information you need without click on it for a more detailed view
  - They clutter up the presentation and make it harder to parse quickly
  - For certain apps and certain views, they sometimes don't show up at all, 
which is confusing and inconsistent

TEST PLAN
  Looks better:
  [images go here]

REPOSITORY
  R134 Discover Software Store

BRANCH
  remove-categories-on-delegates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11842

AFFECTED FILES
  discover/qml/ApplicationDelegate.qml

To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart