D11849: [kdecoration] properly compare opacity values

[Vlad Zagorodniy]

zzag abandoned this revision.
zzag added a comment.


  In D11849#238798 , @davidedmundson 
wrote:
  
  > Whilst qFuzzyCompare is indeed needed for comparing a calculation with a 
value, it's not relevant in all cases, like this.
  >
  > We want setOpacity(actually zero)   to update m_opacity over   
setOpacity(something near zero)  as it hypothetically changes QPainter paths 
which check for actual zero.
  
  
  Oh, I see.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11849

To: zzag, #breeze, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11849: [kdecoration] properly compare opacity values

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Whilst qFuzzyCompare is indeed needed for comparing a calculation with a 
value, it's not relevant in all cases, like this.
  
  We want setOpacity(actually zero)   to update m_opacity over   
setOpacity(something near zero)  as it hypothetically changes QPainter paths 
which check for actual zero.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11849

To: zzag, #breeze, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11849: [kdecoration] properly compare opacity values

[Vlad Zagorodniy]

zzag added a comment.


  In D11849#238233 , @broulik wrote:
  
  > Why not use `qFuzzyCompare`?
  
  
  Opacity can be 0. But yeah, I could also use the +1 trick.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11849

To: zzag, #breeze
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11849: [kdecoration] properly compare opacity values

[Kai Uwe Broulik]

broulik added a comment.


  Why not use `qFuzzyCompare`?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11849

To: zzag, #breeze
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11849: [kdecoration] properly compare opacity values

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.

REPOSITORY
  R31 Breeze

BRANCH
  properly-compare-opacity

REVISION DETAIL
  https://phabricator.kde.org/D11849

AFFECTED FILES
  kdecoration/breezebutton.h
  kdecoration/breezedecoration.cpp

To: zzag, #breeze
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart