zzag created this revision.
zzag added a reviewer: Breeze.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.
REVISION SUMMARY
Qt has its own macro to tell the compiler that the lack of the break
statement is intentional. One of the advantages of using Q_FALLTHROUGH
is that it explicitly says other developers that the break statement is
missing on purpose. Another advantage is that we can use directives,
see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77817
TEST PLAN
Compiled Breeze with GCC 7 and Clang, no "this statement may fall
through" warnings whatsoever.
REPOSITORY
R31 Breeze
BRANCH
q-fallthrough
REVISION DETAIL
https://phabricator.kde.org/D11860
AFFECTED FILES
kstyle/breezesplitterproxy.cpp
To: zzag, #breeze
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
