D12040: [WIP] Add wallpaperplugin.knsrc + QML function to open GHNS dialog

[Chris Holland]

Zren updated this revision to Diff 32247.
Zren edited the summary of this revision.
Zren added a comment.


  Move open GHNS window function from Wallpaper.Image to 
ShellPrivate.WallpaperPlugin

REPOSITORY
  R131 Plasma Wallpapers

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12040?vs=31651&id=32247

REVISION DETAIL
  https://phabricator.kde.org/D12040

AFFECTED FILES
  components/shellprivate/CMakeLists.txt
  components/shellprivate/shellprivateplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.h
  components/shellprivate/wallpaperplugin/wallpaperplugin.knsrc

To: Zren, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12040: [WIP] Add wallpaperplugin.knsrc + QML function to open GHNS dialog

[Chris Holland]

Zren created this revision.
Zren added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Patch 1/2 (other patch is for plasma-desktop)
  
  BUG: #386621
  
  - https://bugs.kde.org/show_bug.cgi?id=386621
  - To find the `Categories=Plasma Wallpaper Plugin` in the 
`wallpaperplugin.knsrc`, I had to find the `Plasma Wallpaper 
Plugin` on the this API url: 
https://api.kde-look.org/ocs/v1/content/categories
  - To find that url, I looked at: 
https://github.com/KDE/ocs-webserver/blob/master/application/modules/default/Bootstrap.php#L1014
  
  Screenshot of the dialog:
  
  F5800268: 2018-04-08___02-02-49.png 
  
  This screenshot is more releavant to Patch 2 for plasma-desktop:
  
  F5800267: 2018-04-08___02-19-12.png 
  
  TODO:
  -
  
  [ ] Move C++ plugin to `components/shellprivate/wallpaperplugin` ? I probably 
need to move the new GHNS code to `components/shellprivate/wallpaperplugin` 
since "desktoppackage" has the widgetexplorer C++ plugins there. I figured I'd 
put up a working patch first.
  [ ] Update `wallpaperComboBox` and `configDialog.wallpaperConfigModel` so we 
don't have to close and reopen the "Configure Desktop" window for the plugin to 
show up in the dropdown.

TEST PLAN
  1. Install both patches
  2. Configure Desktop > Get Wallpaper Plugins > Install something (eg: Ken 
Burns Effect)
  3. Confirm it showed up in `~/.local/share/plasma/wallpapers/`
  4. Close GHNS dialog and Configure Desktop dialog
  5. Reopen Configure Desktop
  6. Confirm "Ken Burns Effect" shows up

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/wallpaperplugin.knsrc

To: Zren, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart