D12055: Remove border around menubars

2019-03-28 Thread Vlad Zagorodniy 
This revision was automatically updated to reflect the committed changes.
Closed by commit R98:1c66db4f34c9: Remove border around menubars (authored by 
zzag).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12055?vs=54576=54969

REVISION DETAIL
  https://phabricator.kde.org/D12055

AFFECTED FILES
  src/gtk318/widgets/_menus.scss
  src/gtk320/widgets/_menus.scss

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: abetts, ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D12055: Remove border around menubars

2019-03-24 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  +1 here too. Go ahead and land this!

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  remove-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: abetts, ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D12055: Remove border around menubars

2019-03-22 Thread Noah Davis 
ndavis added a comment.


  In D12055#436424 , @filipf wrote:
  
  > In D12055#436412 , @ndavis wrote:
  >
  > > I don't see this border at all in the current version of Breeze GTK with 
Firefox. F6711302: Screenshot_20190322_152144.png 

  >
  >
  > Try with a non-default theme
  >
  > F6711393: image.png 
  
  
  Ok, I see what you mean. +1 to this change

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  remove-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: abetts, ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D12055: Remove border around menubars

2019-03-22 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 54576.
zzag added a comment.


  rebase

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12055?vs=35206=54576

BRANCH
  remove-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

AFFECTED FILES
  src/gtk318/widgets/_menus.scss
  src/gtk320/widgets/_menus.scss

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: abetts, ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D12055: Remove border around menubars

2019-03-22 Thread Filip Fila 
filipf added a comment.


  In D12055#436412 , @ndavis wrote:
  
  > I don't see this border at all in the current version of Breeze GTK with 
Firefox. F6711302: Screenshot_20190322_152144.png 

  
  
  Try with a non-default theme
  
  F6711393: image.png 

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: abetts, ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D12055: Remove border around menubars

2019-03-22 Thread Andres Betts 
abetts added a comment.


  +1 for visual improvement

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: abetts, ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D12055: Remove border around menubars

2019-03-22 Thread Noah Davis 
ndavis added a comment.


  I don't see this border at all in the current version of Breeze GTK with 
Firefox. F6711302: Screenshot_20190322_152144.png 


REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: ndavis, filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D12055: Remove border around menubars

2019-03-22 Thread Filip Fila 
filipf added a comment.


  These borders are still pretty bad looking, I think we should go through with 
this.
  
  F6711163: image.png 

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: filipf, jackg, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-07-16 Thread Vlad Zagorodniy 
zzag added a comment.


  @jackg Ping.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg, #vdg
Cc: jackg, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-05-30 Thread Vlad Zagorodniy 
zzag added a comment.


  In D12055#270987 , @ngraham wrote:
  
  > In D12055#270986 , @zzag wrote:
  >
  > > @ngraham Also, who maintains Breeze GTK theme?
  >
  >
  > @jackg does, IIRC.
  
  
  Thanks.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham, jackg
Cc: jackg, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-05-30 Thread Nathaniel Graham 
ngraham added a subscriber: jackg.
ngraham added a comment.


  In D12055#270986 , @zzag wrote:
  
  > @ngraham Also, who maintains Breeze GTK theme?
  
  
  @jackg does, IIRC.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham
Cc: jackg, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-05-30 Thread Vlad Zagorodniy 
zzag added a comment.


  @ngraham Also, who maintains Breeze GTK theme?

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-05-30 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 35206.
zzag added a comment.


  Delete redundant `border: none;` rules

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12055?vs=31705=35206

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

AFFECTED FILES
  Breeze-dark-gtk/gtk-3.18/gtk.css
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/gtk-3.18/gtk.css
  Breeze-gtk/gtk-3.20/gtk.css

To: zzag, #breeze, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-05-30 Thread Nathaniel Graham 
ngraham added a comment.


  I wasn't planning to. :)

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-05-30 Thread Vlad Zagorodniy 
zzag added a comment.


  Please, don't land it yet.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-05-30 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Revisiting this, I think there's value in matching how Breeze does it at even 
if just for simple consistency's sake. If we ever change Breeze, we can change 
this back.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  menubar-border

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-05-30 Thread Vlad Zagorodniy 
zzag added a comment.


  Ping.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-04-16 Thread Vlad Zagorodniy 
zzag reclaimed this revision.
zzag added a comment.


  Oh, I misunderstood you.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-04-15 Thread Nathaniel Graham 
ngraham added a comment.


  In fact, please re-open this. Let's have an actual discussion about this, and 
sorry for the silence so far...

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-04-15 Thread Nathaniel Graham 
ngraham added a comment.


  I didn't want to kill this revision, sorry! Just wanted to throw that out 
there for discussion purposes.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-04-15 Thread Vlad Zagorodniy 
zzag abandoned this revision.
zzag added a comment.


  In D12055#246990 , @ngraham wrote:
  
  > In fact, we've got an open request to //add// this line to the Breeze theme 
for Qt apps...
  >
  > https://bugs.kde.org/show_bug.cgi?id=386306
  
  
  OK, I won't insist on this change. That's not really hard to patch breeze gtk 
theme. :)

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12055: Remove border around menubars

2018-04-15 Thread Nathaniel Graham 
ngraham added a comment.


  In fact, we've got an open request to //add// this line to the Breeze theme 
for Qt apps...
  
  https://bugs.kde.org/show_bug.cgi?id=386306

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D12055

To: zzag, #breeze
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart