D12356: Move volume constants into functions
This revision was automatically updated to reflect the committed changes. Closed by commit R994:c102a76c9538: Move volume constants into functions (authored by nicolasfella). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12356?vs=32583=32584 REVISION DETAIL https://phabricator.kde.org/D12356 AFFECTED FILES src/context.cpp src/context.h src/context_p.h To: nicolasfella, drosca, apol Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D12356: Move volume constants into functions
drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Yeah, sorry, it would actually build, but it wouldn't do what you wanted. REPOSITORY R994 Pulseaudio Qt Bindings BRANCH nopulseheader REVISION DETAIL https://phabricator.kde.org/D12356 To: nicolasfella, drosca, apol Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D12356: Move volume constants into functions
nicolasfella added a comment. Weird, it did build for me so I didn't notice, sorry REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D12356 To: nicolasfella, drosca, apol Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D12356: Move volume constants into functions
nicolasfella updated this revision to Diff 32583. nicolasfella added a comment. - Fix names REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12356?vs=32573=32583 BRANCH nopulseheader REVISION DETAIL https://phabricator.kde.org/D12356 AFFECTED FILES src/context.cpp src/context.h src/context_p.h To: nicolasfella, drosca, apol Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D12356: Move volume constants into functions
drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Yes, that's what I had in mind. But please make it build (`MinimalVolume` in header vs `minimalVolume` in source). Also I think we should use "minimum" instead of "minimal", same with "maximal" -> "maximum". REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D12356 To: nicolasfella, drosca, apol Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D12356: Move volume constants into functions
nicolasfella created this revision. nicolasfella added reviewers: drosca, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Get rid of pulse include in context.h TEST PLAN KDE Connect volume control still works with correct bounds REPOSITORY R994 Pulseaudio Qt Bindings BRANCH nopulseheader REVISION DETAIL https://phabricator.kde.org/D12356 AFFECTED FILES src/context.cpp src/context.h src/context_p.h To: nicolasfella, drosca, apol Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
