D12449: Add hidden system setting group

2018-04-23 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:2b158ac36aa6: Add hidden system setting group (authored 
by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D12449?vs=32813=32878#toc

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12449?vs=32813=32878

REVISION DETAIL
  https://phabricator.kde.org/D12449

AFFECTED FILES
  categories/hidden.desktop

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D12449: Add hidden system setting group

2018-04-23 Thread Marco Martin 
mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> hidden.desktop:5
> +X-KDE-Weight=100
> +Icon=preferences-desktop-default-applications
> +Enabled=false

can you remove the icon?

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12449

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D12449: Add hidden system setting group

2018-04-22 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  We have a KCM (my plasma renderer settings) which we want to hide in
  system settings, but still findable in krunner manual kcmshell5
  invocation. Setting the relevant .desktop to hidden breaks the latter.
  
  This patch creates a group which is hidden. KCMs parented to a hidden
  group remain hidden when shown in a grouped way.

TEST PLAN
  Opened system settings

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12449

AFFECTED FILES
  categories/hidden.desktop

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart