D12468: Enable anti-aliasing for user avatars

2018-04-23 Thread Kirill Tatunov 
ktatunov created this revision.
ktatunov added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ktatunov requested review of this revision.

REVISION SUMMARY
  By default, QT uses fast transformations when scaling pixmaps but it results 
in a very pixelated image. This patch fixes it for avatars in the user manager 
module.

TEST PLAN
  Resolution of the original avatar image is 256x256.
  Before: F5819211: user-manager-before.png 

  After: F5819213: user-manager-after.png 

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12468

AFFECTED FILES
  src/lib/accountmodel.cpp

To: ktatunov, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

2018-04-23 Thread Nathaniel Graham 
ngraham added a comment.


  +1!

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12468

To: ktatunov, #plasma
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

2018-04-23 Thread David Edmundson 
davidedmundson added a comment.


  why ignore aspect ratio?

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12468

To: ktatunov, #plasma
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

2018-04-23 Thread Kirill Tatunov 
ktatunov added a comment.


  In D12468#252342 , @davidedmundson 
wrote:
  
  > why ignore aspect ratio?
  
  
  I kept the default behaviour for this argument since it wasn't what I was 
after. But now that you mention it it would probably be better to use 
Qt::KeepAspectRatio. I don't think anyone likes their avatars 
stretched/squashed.
  Shall I change it to that?

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12468

To: ktatunov, #plasma
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

2018-04-23 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I think so.
  
  Then ship it!

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12468

To: ktatunov, #plasma, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

2018-04-23 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12468

To: ktatunov, #plasma, davidedmundson
Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

2018-04-23 Thread Kirill Tatunov 
ktatunov updated this revision to Diff 32890.
ktatunov added a comment.


  Qt::IgnoreAspectRatio -> Qt::KeepAspectRatio

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12468?vs=32880&id=32890

REVISION DETAIL
  https://phabricator.kde.org/D12468

AFFECTED FILES
  src/lib/accountmodel.cpp

To: ktatunov, #plasma, davidedmundson
Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

2018-05-02 Thread Kirill Tatunov 
ktatunov added a comment.


  Could someone commit this for me please? I don't have a developer account.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D12468

To: ktatunov, #plasma, davidedmundson
Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

2018-05-02 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R128:da05675b4292: Enable anti-aliasing for user avatars 
(authored by ktatunov, committed by davidedmundson).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12468?vs=32890&id=33496

REVISION DETAIL
  https://phabricator.kde.org/D12468

AFFECTED FILES
  src/lib/accountmodel.cpp

To: ktatunov, #plasma, davidedmundson
Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart