D12822: Added null check in OverlayDrawer

2018-05-14 Thread Marco Martin 
mart added a comment.


  ok this can be abandoned then

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12822

To: Dax
Cc: mart, apol, plasma-devel, davidedmundson, hein

D12822: Added null check in OverlayDrawer

2018-05-13 Thread Antonio Davide Trogu 
Dax added a comment.


  Yes it's the same one!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12822

To: Dax
Cc: apol, plasma-devel, davidedmundson, mart, hein

D12822: Added null check in OverlayDrawer

2018-05-12 Thread Aleix Pol Gonzalez 
apol added a comment.


  Already done in https://phabricator.kde.org/D12741.
  
  Or I'm missing something?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12822

To: Dax
Cc: apol, plasma-devel, davidedmundson, mart, hein

D12822: Added null check in OverlayDrawer

2018-05-11 Thread Antonio Davide Trogu 
Dax created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
Dax requested review of this revision.

REVISION SUMMARY
  This patch checks if 'header' property is valid
  
  Tested with Qt 5.10.1 on Android

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12822

AFFECTED FILES
  src/controls/templates/OverlayDrawer.qml

To: Dax
Cc: plasma-devel, apol, davidedmundson, mart, hein