D13042: Do not show activity switcher during fast switches
This revision was automatically updated to reflect the committed changes. Closed by commit R119:13ae9edb85ca: Do not show activity switcher during fast switches (authored by thsurrel, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13042?vs=34774=34919 REVISION DETAIL https://phabricator.kde.org/D13042 AFFECTED FILES imports/activitymanager/switcherbackend.cpp To: thsurrel, #plasma, ivan Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D13042: Do not show activity switcher during fast switches
ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Looks ok to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13042 To: thsurrel, #plasma, ivan Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D13042: Do not show activity switcher during fast switches
thsurrel updated this revision to Diff 34774. thsurrel added a comment. Update the timing to match what is used in KWin and Alt-Tab REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13042?vs=34655=34774 REVISION DETAIL https://phabricator.kde.org/D13042 AFFECTED FILES imports/activitymanager/switcherbackend.cpp To: thsurrel, #plasma, ivan Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D13042: Do not show activity switcher during fast switches
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13042 To: thsurrel, #plasma, ivan Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
D13042: Do not show activity switcher during fast switches
thsurrel planned changes to this revision. thsurrel added a comment. Good point. I had a look, the timeout is set at 90ms by default. But it is configurable (DelayTime), should I try to read the kwin configuration value or can we just go with 90ms ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13042 To: thsurrel, #plasma, ivan Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13042: Do not show activity switcher during fast switches
broulik added a comment. +1 This is the same as KWin does with Alt+Tab, can you check what timeout it uses so we can be consistent here? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13042 To: thsurrel, #plasma, ivan Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13042: Do not show activity switcher during fast switches
thsurrel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When using the keyboard global shortcut to switch quickly between two activities, it does not make sense to start showing the activity switcher, as it does not have time to show completely and just flickers on the left side. This patch modifies the timing when the activity switcher is shown and when the activity is actually switched. It makes switching quickly between two activities snappier. If the user has to search between more activities, the bottleneck will likely not be the small delay before showing the activity switcher. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13042 AFFECTED FILES imports/activitymanager/switcherbackend.cpp To: thsurrel Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
