D13346: Use more contextual strings for some button labels

[Andres Betts]

abetts added a comment.


  In D13346#274450 , @emateli wrote:
  
  > > In D13346#274446 , @abetts 
wrote:
  > >  Could we have a button that enables/disables bluetooth instead? We can 
show the warning message only if it doesn't seem to be working? or for example, 
if it runs into an error when enabling, "then" show a warning sign?
  > > 
  > > Thoughts?
  >
  > A switch like you mention will function perfectly in this case. Possibly 
positioned in the same line with the title (next to it or at the right) so then 
the text and button are not necessary anymore. Also functions in the same way 
as the tray widget(which has a check box instead of a toggle, but it's close 
enough)
  
  
  Agreed, I think we do this for things like Wifi where we don't show a warning 
sign when Wifi is not enabled.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D13346

To: ngraham, #plasma, #vdg, drosca
Cc: emateli, abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13346: Use more contextual strings for some button labels

[Emirald Mateli]

emateli added a comment.


  > In D13346#274446 , @abetts wrote:
  >  Could we have a button that enables/disables bluetooth instead? We can 
show the warning message only if it doesn't seem to be working? or for example, 
if it runs into an error when enabling, "then" show a warning sign?
  > 
  > Thoughts?
  
  A switch like you mention will function perfectly in this case. Possibly 
positioned in the same line with the title (next to it or at the right) so then 
the text and button are not necessary anymore. Also functions in the same way 
as the tray widget(which has a check box instead of a toggle, but it's close 
enough)

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D13346

To: ngraham, #plasma, #vdg, drosca
Cc: emateli, abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13346: Use more contextual strings for some button labels

[Andres Betts]

abetts added a comment.


  In D13346#274427 , @ngraham wrote:
  
  > Red is for errors, orange is for warnings, and blue is for information. The 
red is not as harsh as it used to be, but do you think orange would be a more 
appropriate color?
  
  
  I think so. Red conveys that there is something wrong about your Bluetooth 
set up. In fact, I am not even sure if we should have this message at all. 
Could we have a button that enables/disables bluetooth instead? We can show the 
warning message only if it doesn't seem to be working? or for example, if it 
runs into an error when enabling, "then" show a warning sign?
  
  Thoughts?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D13346

To: ngraham, #plasma, #vdg, drosca
Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D13346: Use more contextual strings for some button labels

[Nathaniel Graham]

ngraham added a comment.


  Red is for errors, orange is for warnings, and blue is for information. The 
red is not as harsh as it used to be, but do you think orange would be a more 
appropriate color?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D13346

To: ngraham, #plasma, #vdg, drosca
Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D13346: Use more contextual strings for some button labels

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Every Bluetooth error's "fix this error" button's text is "Fix it". However, 
some issues are not actually problems per se from the user's perspective, so 
the text can imply the existence of a problem where none exists.
  
  In the case where the Bluetooth adapter is powered off or disables, display a 
more contextually appropriate string instead ("Turn On" and "Enable", 
respectively)
  
  CCBUG: 394778
  FIXED-IN: 5.14

TEST PLAN
  [image goes here]

REPOSITORY
  R97 Bluedevil

BRANCH
  more-contextual-fix-problem-button-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13346

AFFECTED FILES
  src/kcmodule/common/systemcheck.cpp
  src/sendfile/discoverwidget.cpp

To: ngraham, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13346: Use more contextual strings for some button labels

[Andres Betts]

abetts added a comment.


  +1
  
  I feel this is a must. We are trying to convey that the user needs to enable 
Bluetooth in order to make it work. There is real issue there. In fact, could 
we maybe change the color message from RED to something more informational?

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D13346

To: ngraham, #plasma, #vdg, drosca
Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D13346: Use more contextual strings for some button labels

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:c7f72367599b: Use more contextual strings for some button 
labels (authored by ngraham).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13346?vs=35583=35607

REVISION DETAIL
  https://phabricator.kde.org/D13346

AFFECTED FILES
  src/kcmodule/common/systemcheck.cpp
  src/sendfile/discoverwidget.cpp

To: ngraham, #plasma, #vdg, drosca
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13346: Use more contextual strings for some button labels

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D13346

To: ngraham, #plasma, #vdg
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart