D13357: Use logging categories in a few dataengines

2018-06-08 Thread Rik Mills 
rikmills added a comment.


  @davidedmundson Seems so. Thank you.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13357

To: davidedmundson, #plasma, mart
Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13357: Use logging categories in a few dataengines

2018-06-08 Thread David Edmundson 
davidedmundson added a comment.


  Thanks. Hopefully fixed?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13357

To: davidedmundson, #plasma, mart
Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13357: Use logging categories in a few dataengines

2018-06-07 Thread Rik Mills 
rikmills added a comment.


  Build errors with this:
  
  
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.10/44/console
  
  https://build.neon.kde.org/job/bionic_unstable_kde_plasma-workspace/102/
  
  https://kci.pangea.pub/job/cosmic_unstable_plasma-workspace/
  
  13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 
SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:76: 
undefined reference to `DATAENGINE_SNI()'
  13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 
SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:76: 
undefined reference to `DATAENGINE_SNI()'
  13:46:35 
CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_engine.cpp.o:
 In function `StatusNotifierItemEngine::registerWatcher(QString const&)':
  13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 
SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:118: 
undefined reference to `DATAENGINE_SNI()'
  13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 
SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:118: 
undefined reference to `DATAENGINE_SNI()'
  13:46:35 
CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_engine.cpp.o:
 In function `StatusNotifierItemEngine::unregisterWatcher(QString const&)':
  13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 
SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:126: 
undefined reference to `DATAENGINE_SNI()'
  13:46:35 
CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_engine.cpp.o:/home/jenkins/workspace/Plasma
 plasma-workspace kf5-qt5 
SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:126: 
more undefined references to `DATAENGINE_SNI()' follow
  13:46:35 collect2: error: ld returned 1 exit status

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13357

To: davidedmundson, #plasma, mart
Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13357: Use logging categories in a few dataengines

2018-06-07 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a8573d1be5a4: Use logging categories in a few dataengines 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13357?vs=35598&id=35769

REVISION DETAIL
  https://phabricator.kde.org/D13357

AFFECTED FILES
  dataengines/statusnotifieritem/CMakeLists.txt
  dataengines/statusnotifieritem/statusnotifieritem_engine.cpp
  dataengines/statusnotifieritem/systemtraytypes.cpp
  dataengines/time/CMakeLists.txt
  dataengines/time/timeengine.cpp

To: davidedmundson, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13357: Use logging categories in a few dataengines

2018-06-05 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Compiles

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13357

AFFECTED FILES
  dataengines/statusnotifieritem/CMakeLists.txt
  dataengines/statusnotifieritem/statusnotifieritem_engine.cpp
  dataengines/statusnotifieritem/systemtraytypes.cpp
  dataengines/time/CMakeLists.txt
  dataengines/time/timeengine.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart