D13919: [Fonts KCM] Generate font rendering previews only on X

2018-07-09 Thread Kai Uwe Broulik 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3fd0bf5cef8a: [Fonts KCM] Generate font rendering 
previews only on X (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13919?vs=37235=37446

REVISION DETAIL
  https://phabricator.kde.org/D13919

AFFECTED FILES
  kcms/fonts/previewimageprovider.cpp

To: broulik, #plasma, fvogt
Cc: rkflx, progwolff, alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13919: [Fonts KCM] Generate font rendering previews only on X

2018-07-08 Thread Henrik Fehlauer 
rkflx added subscribers: progwolff, rkflx.
rkflx added a comment.


  (@progwolff CC'ing you here in case later on you're motivated to look into 
Wayland support for the feature you contributed – once you're less busy with 
more important things ;)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13919

To: broulik, #plasma, fvogt
Cc: rkflx, progwolff, alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13919: [Fonts KCM] Generate font rendering previews only on X

2018-07-06 Thread Kai Uwe Broulik 
broulik added a comment.


  Yes, it says in the commit message

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13919

To: broulik, #plasma, fvogt
Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13919: [Fonts KCM] Generate font rendering previews only on X

2018-07-06 Thread Alexey Min 
alexeymin added a comment.


  This is probably for  BUG: 396214 ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13919

To: broulik, #plasma, fvogt
Cc: alexeymin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13919: [Fonts KCM] Generate font rendering previews only on X

2018-07-06 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It uses Xft unconditionally and crashes the entire module when run on Wayland.
  
  BUG: 396214
  FIXED-IN: 5.13.3

TEST PLAN
  Without the previews, the delegate in the combo doesn't fill entire popup 
width but that's a separate bug and mostly cosmetic and a lot better than the 
entire thing crashing :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13919

AFFECTED FILES
  kcms/fonts/previewimageprovider.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart