D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks, now the name shows up in the combobox. However I'm not sure the 
images are fetched properly. I get a black background, rather than an image.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13930

To: tagorechandanreddy, #plasma, ngraham
Cc: ngraham, jriddell, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

[Tagore Chandan Reddy]

tagorechandanreddy updated this revision to Diff 37297.
tagorechandanreddy added a comment.


  Fixed siodprovider.json file. It should work now.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13930?vs=37288=37297

REVISION DETAIL
  https://phabricator.kde.org/D13930

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/siodprovider.cpp
  dataengines/potd/siodprovider.h
  dataengines/potd/siodprovider.json

To: tagorechandanreddy, #plasma, ngraham
Cc: ngraham, jriddell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  No name shows up in the list:
  
  F6043949: Screenshot_20180707_173801.png 

  
  Also, using it doesn't seem to actually work; the wallpaper remains black.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13930

To: tagorechandanreddy, #plasma, ngraham
Cc: ngraham, jriddell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

[Tagore Chandan Reddy]

tagorechandanreddy added a comment.


  And regarding the license of the images, Space.com acquires them from twitter 
and other public outlets that belong to NASA and its Astronauts. All images are 
taken by Space.com from public domains with credit to the original 
contributors. No other mention of any additional copyright notices.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13930

To: tagorechandanreddy, #plasma
Cc: jriddell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

[Tagore Chandan Reddy]

tagorechandanreddy updated this revision to Diff 37288.
tagorechandanreddy added a comment.


  Made copyright, translation changes as suggested.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13930?vs=37285=37288

REVISION DETAIL
  https://phabricator.kde.org/D13930

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/siodprovider.cpp
  dataengines/potd/siodprovider.h
  dataengines/potd/siodprovider.json

To: tagorechandanreddy, #plasma
Cc: jriddell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

[Friedrich W. H. Kossebau]

kossebau added a subscriber: jriddell.
kossebau added a comment.


  Thanks for offering this for inclusion. No time to test myself currently.
  
  Important: can you tell what license space.com has on those images? Can they 
be used e.g. without a fee by 3rd-party software, like this plugin? I could not 
find a hint on the linked page on a quick look.
  
  BTW, while I did some fixes to the potd dataengine , I am not the maintainer 
of it (nor plan to be). So it has to be someone else deciding about whether 
this plugin can be added.
  Given there seems no maintainer of this dataengine these days it would have 
to be the Plasma team in general, or the person overseeing things like the 
release manager (@jriddell).

INLINE COMMENTS

> siodprovider.h:2-3
> +/*
> + *   Copyright (C) 2007 Tobias Koenig 
> + *   Copyright  2008 by Anne-Marie Mahfouf  
> + *

Please update the copyright of all files, your name and the year is missing 
here.

> siodprovider.json:4
> +"Description": "Siod Provider",
> +"Description[ca@valencia]": "Proveïdor Siod",
> +"Description[ca]": "Proveïdor Siod",

The KDE translation system needs such in-source translations to be added to the 
translation database directly. This is a work done by the translator teams, but 
who first need to see the original string.
The daily-run translation updating script (called scripty) will extract any 
strings to translate and update with strings from the translation database, but 
also remove any translations from the sources which are not in the database.
So adding translations here directly will result in scripty removing them 
simply on next run. Thus no use to add them -> remove all here :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13930

To: tagorechandanreddy, #plasma, kossebau
Cc: jriddell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

[Tagore Chandan Reddy]

tagorechandanreddy created this revision.
tagorechandanreddy added reviewers: Plasma, kossebau.
tagorechandanreddy added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
tagorechandanreddy requested review of this revision.

REVISION SUMMARY
  Added new Picture of the Day provider handling 'Image of the day' from 
Space.com at address:
  http://www.space.com/imageoftheday/
  
  Language translations need looking into.

TEST PLAN
  All plugins should work as usual. Language translations may need few 
corrections.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13930

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/siodprovider.cpp
  dataengines/potd/siodprovider.h
  dataengines/potd/siodprovider.json

To: tagorechandanreddy, #plasma, kossebau
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart