D14068: add -P switch to one-shot redshift call

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Superseded by D23330 .

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D14068

To: ngraham, #plasma, romangg, martinkostolny, grmat
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D14068: add -P switch to one-shot redshift call

[mat gr]

grmat added a comment.


  In D14068#332672 , @davidedmundson 
wrote:
  
  > what happens to users on older versions?
  
  
  It breaks, as redshift <1.12 will exit with "invalid option -- 'P'".
  
  I initially just thought of this as packaging responsibility, however, users 
might install those applets independently from distribution's packages.
  
  It would be possible to make a runtime check, look for the version no. with 
`redshift -V` and add the -P switch dynamically. However, I'm not familiar with 
QML or where this call would be added. I thought of something like
  
...
property string redshiftCompat: getInstalledRedshiftVersion().split(' ')[1] 
< '1.12' ? '' : '-P'
property string redshiftOneTimeCommand: 'redshift -O ' + redshiftCompat + 
...

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D14068

To: grmat, #plasma, romangg, martinkostolny
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14068: add -P switch to one-shot redshift call

[David Edmundson]

davidedmundson added a comment.


  > since 1.12.
  
  what happens to users on older versions?

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D14068

To: grmat, #plasma, romangg, martinkostolny
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14068: add -P switch to one-shot redshift call

[Nathaniel Graham]

ngraham added reviewers: Plasma, romangg, martinkostolny.
ngraham added a comment.


  #plasma  folks ping!

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D14068

To: grmat, #plasma, romangg, martinkostolny
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14068: add -P switch to one-shot redshift call

[mat gr]

grmat added a comment.


  I was hoping the bug would get linked in automatically... anyways, here it 
is, with additional information: https://bugs.kde.org/show_bug.cgi?id=395641

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D14068

To: grmat
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14068: add -P switch to one-shot redshift call

[mat gr]

grmat created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
grmat requested review of this revision.

REVISION SUMMARY
  This trivial patch adds the missing parameter to get the familiar behaviour 
working for redshift versions since 1.12.
  
  BUG: 395641

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D14068

AFFECTED FILES
  package/contents/ui/main.qml

To: grmat
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart