D14133: WIP: [kdecoration] Make shadows lighter

2018-07-15 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  An excellent tweak. I think this looks better--more subtle and more 
professional, but still retains the original goal. Good for you for listening 
to user feedback, too. :)

REPOSITORY
  R31 Breeze

BRANCH
  refine-decoration-shadows

REVISION DETAIL
  https://phabricator.kde.org/D14133

To: zzag, #vdg, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14133: WIP: [kdecoration] Make shadows lighter

2018-07-15 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 37810.
zzag added a comment.


  Tweak small and medium shadows

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14133?vs=37805=37810

BRANCH
  refine-decoration-shadows

REVISION DETAIL
  https://phabricator.kde.org/D14133

AFFECTED FILES
  kdecoration/breezedecoration.cpp

To: zzag, #vdg, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14133: WIP: [kdecoration] Make shadows lighter

2018-07-15 Thread Nathaniel Graham 
ngraham added a comment.


  +1, I definitely prefer the version with the shadow box moved up a bit with a 
little bit of lightening. I think that looks fantastic!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D14133

To: zzag, #vdg, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14133: WIP: [kdecoration] Make shadows lighter

2018-07-15 Thread Vlad Zagorodniy 
zzag added a comment.


  F6107977: Screenshot_20180715_175013.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D14133

To: zzag, #vdg, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14133: WIP: [kdecoration] Make shadows lighter

2018-07-15 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 37805.
zzag added a comment.


  Make key shadow lighter for Large and Very large shadows

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14133?vs=37803=37805

BRANCH
  refine-decoration-shadows

REVISION DETAIL
  https://phabricator.kde.org/D14133

AFFECTED FILES
  kdecoration/breezedecoration.cpp

To: zzag, #vdg, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14133: WIP: [kdecoration] Make shadows lighter

2018-07-15 Thread Vlad Zagorodniy 
zzag added a comment.


  F6107872: Screenshot_20180715_174127.png 

  
  Maybe, we should make contrast/ambiance shadows lighter...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D14133

To: zzag, #vdg, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14133: WIP: [kdecoration] Make shadows lighter

2018-07-15 Thread Vlad Zagorodniy 
zzag added a comment.


  Slightly moved box shadows
  --
  
  Small:
  F6107843: 05-after-small.png 
  
  Medium:
  F6107845: 06-after-medium.png 
  
  Large:
  F6107848: 07-after-large.png 
  
  Very large:
  F6107850: 08-after-very-large.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D14133

To: zzag, #vdg, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14133: WIP: [kdecoration] Make shadows lighter

2018-07-15 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 37803.
zzag added a comment.


  Move box shadows up

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14133?vs=37801=37803

BRANCH
  refine-decoration-shadows

REVISION DETAIL
  https://phabricator.kde.org/D14133

AFFECTED FILES
  kdecoration/breezedecoration.cpp

To: zzag, #vdg, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14133: WIP: [kdecoration] Make shadows lighter

2018-07-15 Thread Nathaniel Graham 
ngraham added a comment.


  IMHO the problem here is not the darkness, but how much darker the bottom 
edge is than the sides. My recommendation would be to move the shadow boxes up 
a few pixels instead of lightning everything.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D14133

To: zzag, #vdg, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart