D14489: [ProcessModel] Support high dpi for window pixmaps

2018-07-30 Thread David Edmundson 
davidedmundson added a comment.


  KWindowSystem::icon doesn't set a DPR on the returned pixmap  which sounds 
wrong.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D14489

To: broulik, #plasma, davidedmundson
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14489: [ProcessModel] Support high dpi for window pixmaps

2018-07-30 Thread Kai Uwe Broulik 
broulik added a comment.


  Interesting. Without this patch, I had some icons come out too small, will 
investigate.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D14489

To: broulik, #plasma, davidedmundson
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14489: [ProcessModel] Support high dpi for window pixmaps

2018-07-30 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


QPixmap KWindowSystem::icon(WId win, int width, int height, bool scale, int 
flags, NETWinInfo *info)
{
Q_D(KWindowSystem);
width *= qApp->devicePixelRatio();
height *= qApp->devicePixelRatio();

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D14489

To: broulik, #plasma, davidedmundson
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14489: [ProcessModel] Support high dpi for window pixmaps

2018-07-30 Thread David Edmundson 
davidedmundson added a comment.


  Not here, no.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D14489

To: broulik, #plasma, davidedmundson
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14489: [ProcessModel] Support high dpi for window pixmaps

2018-07-30 Thread Nathaniel Graham 
ngraham added a comment.


  Should this be `devicePixelRatioF()` to support fractional scale factors?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D14489

To: broulik, #plasma, davidedmundson
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14489: [ProcessModel] Support high dpi for window pixmaps

2018-07-30 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Request larger pixmaps and set `devicePixelRatio` accordingly

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D14489

AFFECTED FILES
  processui/ProcessModel.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart