D14697: X11: set GDK_SCALE (try 2)
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R120:31e1a1a96ca2: X11: set GDK_SCALE (try 2) (authored by eszlari, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14697?vs=39325=43897 REVISION DETAIL https://phabricator.kde.org/D14697 AFFECTED FILES startkde/startkde.cmake To: eszlari, davidedmundson, ngraham, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
eszlari added a comment. peter.eszl...@gmail.com REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
ngraham added a comment. @eszlari, can you provide an email address so we can land this with the proper authorship information? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
ngraham added a comment. Peter, can you provide an email address so we can land this with the proper authorship information? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
davidedmundson added a comment. sure. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
ngraham added a comment. I think that would make sense. @davidedmundson do you agree? It would be nice to have three months to live with this and see if there are any bugs (my testing is clean FWIW). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
broulik resigned from this revision. broulik added a comment. I guess this can go in so we can have a full cycle of testing? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in startkde.cmake:98 > Where does `kdeglobals_kscreen_scalefactor` come from? kstartupconfig5, which reads startupconfigkeys to see what to extract. They then get set as env vars. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma, broulik Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
eszlari added inline comments. INLINE COMMENTS > broulik wrote in startkde.cmake:98 > Where does `kdeglobals_kscreen_scalefactor` come from? Line 52. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma, broulik Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
broulik added inline comments. INLINE COMMENTS > startkde.cmake:98 > export QT_SCREEN_SCALE_FACTORS="$kdeglobals_kscreen_screenscalefactors" > +if [ "$kdeglobals_kscreen_scalefactor" -eq "2" ] || [ > "$kdeglobals_kscreen_scalefactor" -eq "3" ]; then > +export GDK_SCALE=$kdeglobals_kscreen_scalefactor Where does `kdeglobals_kscreen_scalefactor` come from? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma, broulik Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
ngraham added a comment. @davidedmundson 5.14 was just released; should we give this a shot for 5.15? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma, broulik Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
ngraham added a comment. It works well enough for me so far. Can we get some more testing? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma, broulik Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Please hang on, we need to more thorougly test this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma, broulik Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
ngraham accepted this revision. ngraham added a reviewer: Plasma. ngraham added a comment. This revision is now accepted and ready to land. Tested this out and it works flawlessly for Firefox, Lollypop, and GIMP (to the extent that GIMP does support HiDPI) with the integer scale factor use case as long as the Font DPI settings haven't been monkeyed with. But that would be a separate issue, since they are known to conflict. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 To: eszlari, davidedmundson, ngraham, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14697: X11: set GDK_SCALE (try 2)
eszlari created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. eszlari requested review of this revision. REVISION SUMMARY BUG: 387849 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14697 AFFECTED FILES startkde/startkde.cmake To: eszlari Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
