D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd updated this revision to Diff 41182.
smithjd added a comment.


  - [KRunner] Re-work the shortcut handling to allow modifying the shortcuts.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14739?vs=39467=41182

BRANCH
  master-krunnerbashkeybindings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14739

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/view.cpp
  krunner/view.h
  lookandfeel/contents/runcommand/RunCommand.qml

To: smithjd, #plasma, ngraham
Cc: davidedmundson, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd added a comment.


  Perhaps the intent of this patch could change to adding a KShortcutsDialog to 
the kcm where the MOVETOSTARTOFLINE and MOVETOENDOFLINE keyboard shortcuts 
could be reassigned?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma, ngraham
Cc: davidedmundson, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd added a comment.


  In D14739#306749 , @davidedmundson 
wrote:
  
  > We also have
  >
  > system settings -> shortcuts -> standard shortcuts
  >
  > These can have alternatives which would work for this. I don't know if 
these work with QQC2 TextFields, we should fix it if not. Setting alternatives 
would require unsetting 2 existing default application shortcuts, leaving 
CTRL-S and CTRL-E unavailable for default actions for other applications. 
Setting alternatives works for textFields.
  >
  > Thanks for kconfig magic you can override them (without a gui) on a per-app 
basis albeit there's no UI for that.
  
  
  I can't seem to find any information on this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma, ngraham
Cc: davidedmundson, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[David Edmundson]

davidedmundson added a comment.


  We also have
  
  system settings -> shortcuts -> standard shortcuts
  
  These can have alternatives which would work for this. I don't know if these 
work with QQC2 TextFields, we should fix it if not.
  
  Thanks for kconfig magic you can override them (without a gui) on a per-app 
basis albeit there's no UI for that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma, ngraham
Cc: davidedmundson, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd added a comment.


  Most of the keys on that side of the keyboard are already bound globally into 
combos, so the best solution IMO is to intercept the required keycombos in 
KRunner instead of having to rearrange the global app keycombos around KRunner. 
This is what this patch does to implement bash-style cursor jumps in KRunner, 
though this is not so great on the HIG front as the intercepted combos are both 
standard application shortcuts, also duplicating the standard application 
shortcuts for beginning of line / end of line.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma, ngraham
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Sorry, I'm with Kai on this, aspecially because one of the proposed new 
shortcuts conflicts with an existing shortcut that it's possible to use here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma, ngraham
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[Kai Uwe Broulik]

broulik added a comment.


  You can't and I don't see why you can't just use Home/End. Sorry.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd added a comment.


  Yes, except the CTRL + S combo is default for save in other applications, 
with no easy way I can think of to reassign it for just KRunner.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[Kai Uwe Broulik]

broulik added a comment.


  I don't understand. Also, you can change the default shortcut from Home/End 
to whatever you like.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd added a comment.


  I now see that KDE has default application shortcuts for beginning of line 
and end of line (HOME and END) and skip word forwards or backwards (CTRL + 
RARROW/LARROW), that also work in KRunner, that should obsolete this patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd added a comment.


  I tend to frequenty hit additional keys while not watching the runner window. 
Although the shortcut is no longer in common with Bash (the CTRL + S shortcut 
would also have made more sense for Bash) the idea is the same. You can already 
do this from the keyboard, but it requires a select all keycombo AND an arrow 
key each time you need to jump forward or backwards.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[Kai Uwe Broulik]

broulik added a comment.


  Can you explain the rationale behind this? Since you've seemingly randomly 
changed the shortcut, it doesn't seem like a "common" shortcut sheme?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd updated this revision to Diff 39467.
smithjd added a comment.


  - [KRunner] Change start of line shortcut to CTRL + S.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14739?vs=39437=39467

BRANCH
  master-krunnerbashkeybindings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14739

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: smithjd, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[Kai Uwe Broulik]

broulik added a comment.


  Ctrl+A is reserved for "Select All"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14739

To: smithjd
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14739: [KRunner] Bash-inspired keyboard shortcuts for go to start or end of line.

[James Smith]

smithjd created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
smithjd requested review of this revision.

REVISION SUMMARY
  CTRL + A moves the cursor to the beginning of the text entry,
  CTRL + E moves it to the end.

TEST PLAN
  Open KRunner, enter some text. Check if CTRL + A moves the
  cursor to before the first character in the textfield. Next, check if 
  CTRL + E moves the cursor back to the empty space after the text.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master-krunnerbashkeybindings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14739

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: smithjd
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart