D14806: [AppStream Runner] Reduce verbosity of log output

2018-09-13 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8d945c2e5547: [AppStream Runner] Reduce verbosity of log 
output (authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14806?vs=41126=41542

REVISION DETAIL
  https://phabricator.kde.org/D14806

AFFECTED FILES
  runners/appstream/appstreamrunner.cpp

To: bruns, #plasma, ngraham, davidedmundson
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14806: [AppStream Runner] Reduce verbosity of log output

2018-09-13 Thread Stefan Brüns 
bruns added a comment.


  @apol Still waiting for review ...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14806

To: bruns, #plasma, apol, ngraham
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14806: [AppStream Runner] Reduce verbosity of log output

2018-09-10 Thread Stefan Brüns 
bruns added a comment.


  Ping!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14806

To: bruns, #plasma, apol, ngraham
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14806: [AppStream Runner] Reduce verbosity of log output

2018-09-06 Thread Stefan Brüns 
bruns updated this revision to Diff 41126.
bruns added a comment.


  rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14806?vs=40774=41126

BRANCH
  arcpatch-D14806

REVISION DETAIL
  https://phabricator.kde.org/D14806

AFFECTED FILES
  runners/appstream/appstreamrunner.cpp

To: bruns, #plasma, apol, ngraham
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14806: [AppStream Runner] Reduce verbosity of log output

2018-09-02 Thread Stefan Brüns 
bruns added a comment.


  Would be nice to get this in soon, the current state logs a message everytime 
you type a character in KRunner.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14806

To: bruns, #plasma, apol, ngraham
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14806: [AppStream Runner] Reduce verbosity of log output

2018-08-31 Thread Stefan Brüns 
bruns updated this revision to Diff 40774.
bruns added a comment.


  rebase after D14807 

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14806?vs=39636=40774

BRANCH
  appstream_runner_3

REVISION DETAIL
  https://phabricator.kde.org/D14806

AFFECTED FILES
  runners/appstream/appstreamrunner.cpp

To: bruns, #plasma, apol, ngraham
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14806: [AppStream Runner] Reduce verbosity of log output

2018-08-31 Thread Stefan Brüns 
bruns added a comment.


  In D14806#316424 , @apol wrote:
  
  > Because your commits change all very closely related things and even fix 
each other.
  
  
  first yes, second no.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14806

To: bruns, #plasma, apol, ngraham
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14806: [AppStream Runner] Reduce verbosity of log output

2018-08-28 Thread Aleix Pol Gonzalez 
apol added a comment.


  Because your commits change all very closely related things and even fix each 
other.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14806

To: bruns, #plasma, apol, ngraham
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14806: [AppStream Runner] Reduce verbosity of log output

2018-08-22 Thread Stefan Brüns 
bruns requested review of this revision.
bruns added a comment.


  Why should I squash the commits? Each one:
  
  - compiles **and** works on its own
  - addresses a slightly different issue
  
  Citing from 
https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets
  
  > OTOH, commits should be preferably "atomic" - not splittable. That means 
that every bugfix, feature, refactoring or reformatting should go into an own 
commit. This, too, improves the readability of the history.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14806

To: bruns, #plasma, apol, ngraham
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14806: [AppStream Runner] Reduce verbosity of log output

2018-08-15 Thread Aleix Pol Gonzalez 
apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  Please squash all changes

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14806

To: bruns, #plasma, apol
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14806: [AppStream Runner] Reduce verbosity of log output

2018-08-15 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM, maybe commit once only? xD

REPOSITORY
  R120 Plasma Workspace

BRANCH
  appstream_runner_3

REVISION DETAIL
  https://phabricator.kde.org/D14806

To: bruns, #plasma, apol
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D14806: [AppStream Runner] Reduce verbosity of log output

2018-08-13 Thread Stefan Brüns 
bruns created this revision.
bruns added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Its rather pointless to spew an error message each time a query is done.
  Output the warning message just once (on the default logging level), and
  output further messages only at debug level.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  appstream_runner_3

REVISION DETAIL
  https://phabricator.kde.org/D14806

AFFECTED FILES
  runners/appstream/appstreamrunner.cpp

To: bruns, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart