D14905: Warn on logout screen when another user is logged in

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, harmathy.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Since we have a unified screen for logging out and shutting down, the hint is 
always shown as the user could click on "Logout" but then shut down anyway.

TEST PLAN
  F6202221: Screenshot_20180817_204234.png 

  Should we show the name(s) of the other user(s), with avatar? But that could 
easily clutter up the view? It's quite an edge-case anyway.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14905

AFFECTED FILES
  components/sessionsprivate/sessionsmodel.cpp
  components/sessionsprivate/sessionsmodel.h
  lookandfeel/contents/logout/Logout.qml

To: broulik, #plasma, #vdg, harmathy
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14905: Warn on logout screen when another user is logged in

[Nathaniel Graham]

ngraham added a comment.


  Big +1 for the concept. Only one string change proposal, down below:

INLINE COMMENTS

> Logout.qml:147
> +font.italic: true
> +text: i18ndp("plasma_lookandfeel_org.kde.lookandfeel", "One 
> other user is currently logged in.",
> + "%1 other users are currently logged in.", 
> sessionsModel.count)

How about also adding something that reinforces why there's a risk. How about 
this:

"One other user is currently logged in. If the computer shut down or rebooted, 
that user may lose work."

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14905

To: broulik, #plasma, #vdg, harmathy
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14905: Warn on logout screen when another user is logged in

[David Edmundson]

davidedmundson added a comment.


  When do we want unused sessions?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14905

To: broulik, #plasma, #vdg, harmathy
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14905: Warn on logout screen when another user is logged in

[Kai Uwe Broulik]

broulik added a comment.


  In D14905#310978 , @davidedmundson 
wrote:
  
  > When do we want unused sessions?
  
  
  Not sure. Does it recycle them or discard them after a while? They keep 
piling up usually ..

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14905

To: broulik, #plasma, #vdg, harmathy
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14905: Warn on logout screen when another user is logged in

[Marco Martin]

mart added a comment.


  to expand on the concept, maybe could be nice as well a kauthorized key to 
actually letting only logout when there is somebody else logged in

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14905

To: broulik, #plasma, #vdg, harmathy
Cc: mart, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D14905: Warn on logout screen when another user is logged in

[Kai Uwe Broulik]

broulik updated this revision to Diff 40042.
broulik edited the test plan for this revision.
broulik added a comment.


  - Update wording

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14905?vs=39938&id=40042

REVISION DETAIL
  https://phabricator.kde.org/D14905

AFFECTED FILES
  components/sessionsprivate/sessionsmodel.cpp
  components/sessionsprivate/sessionsmodel.h
  lookandfeel/contents/logout/Logout.qml

To: broulik, #plasma, #vdg, harmathy
Cc: mart, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D14905: Warn on logout screen when another user is logged in

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  +1 shipit!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14905

To: broulik, #plasma, #vdg, harmathy, ngraham
Cc: mart, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D14905: Warn on logout screen when another user is logged in

[Nathaniel Graham]

ngraham added a comment.


  In D14905#311825 , @mart wrote:
  
  > to expand on the concept, maybe could be nice as well a kauthorized key to 
actually letting only logout when there is somebody else logged in
  
  
  That would be appropriate for non-admin users, but I feel fairly strongly 
that admin users should always be able to shut down and reboot the computer 
when other users are logged in. They're admins, after all, and should 
presumably know best.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14905

To: broulik, #plasma, #vdg, harmathy, ngraham
Cc: mart, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D14905: Warn on logout screen when another user is logged in

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:dd149d62b61c: Warn on logout screen when another user is 
logged in (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14905?vs=40042&id=40051

REVISION DETAIL
  https://phabricator.kde.org/D14905

AFFECTED FILES
  components/sessionsprivate/sessionsmodel.cpp
  components/sessionsprivate/sessionsmodel.h
  lookandfeel/contents/logout/Logout.qml

To: broulik, #plasma, #vdg, harmathy, ngraham
Cc: mart, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D14905: Warn on logout screen when another user is logged in

[Andres Betts]

abetts added a comment.


  This makes good sense in that admin world, more business style. I think they 
would appreciate it. I would probably look for a string that is a little 
shorter.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14905

To: broulik, #plasma, #vdg, harmathy, ngraham
Cc: abetts, mart, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol