D14924: Prevent paste in screen locker (alternative approach)
This revision was automatically updated to reflect the committed changes. Closed by commit R133:1638db3fefca: Prevent paste in screen locker (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14924?vs=40043&id=40049#toc REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14924?vs=40043&id=40049 REVISION DETAIL https://phabricator.kde.org/D14924 AFFECTED FILES greeter/greeterapp.cpp To: davidedmundson, #plasma, mart Cc: mart, graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D14924: Prevent paste in screen locker (alternative approach)
davidedmundson updated this revision to Diff 40043. davidedmundson edited the summary of this revision. davidedmundson added a comment. Update comment for clarity, use different mimedata REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14924?vs=39983&id=40043 REVISION DETAIL https://phabricator.kde.org/D14924 AFFECTED FILES greeter/greeterapp.cpp To: davidedmundson, #plasma Cc: mart, graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D14924: Prevent paste in screen locker (alternative approach)
mart added a comment. i lean for this solution as well ( a garbage value in the clipboard would work even if klipper is not used, or a different similar thing is used as well?) REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D14924 To: davidedmundson, #plasma Cc: mart, graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D14924: Prevent paste in screen locker (alternative approach)
davidedmundson added a comment. But the bug is klipper specific behaviour. In hindsight the mimetype doesn't actually matter, there's no text/plain so klipper wouldn't save anyway. The important part is that we have something non-empty, non-useful. That should work in all clipboard managers. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D14924 To: davidedmundson, #plasma Cc: graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14924: Prevent paste in screen locker (alternative approach)
graesslin added a comment. I like the other solution better as it doesn't depend on Klipper specific behavior. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D14924 To: davidedmundson, #plasma Cc: graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14924: Prevent paste in screen locker (alternative approach)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY KScreenlocker tries to clear the clipboard on load. However, klipper also (by default) automatically keeps the last relevant item in the clipboard. Whilst both parts work correctly, Plasma as a whole does not. This became a problem when we added the reveal password button as it is a data leak. Instead of clearing the clipboard this patch replaces it with a real entry, but with a dummy mime value that is of no value to anyone, especially a textfield. By using x-kde-passwordManageHint we can prevent klipper from storing this entry so it's completely transparent with a working clipboard after the session is complete. My preferred solution of the two BUG: 388049 TEST PLAN Reproduced issue Made this patch Tried pasting in session Nothing happned Logged in Could paste REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D14924 AFFECTED FILES greeter/greeterapp.cpp To: davidedmundson, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
