D15201: Move logout-greeter into it's own subdir out of ksmserver

2018-10-10 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f4ac46f0569d: Move logout-greeter into its own 
subdir out of ksmserver (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15201?vs=41608=43298#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15201?vs=41608=43298

REVISION DETAIL
  https://phabricator.kde.org/D15201

AFFECTED FILES
  CMakeLists.txt
  ksmserver/CMakeLists.txt
  ksmserver/logout-greeter/CMakeLists.txt
  ksmserver/logout-greeter/main.cpp
  ksmserver/logout-greeter/shutdowndlg.cpp
  ksmserver/logout-greeter/shutdowndlg.h
  ksmserver/logout-greeter/tests/CMakeLists.txt
  ksmserver/logout-greeter/tests/main.cpp
  logout-greeter/CMakeLists.txt
  logout-greeter/main.cpp
  logout-greeter/shutdowndlg.cpp
  logout-greeter/shutdowndlg.h
  logout-greeter/tests/CMakeLists.txt
  logout-greeter/tests/config.h.cmake
  logout-greeter/tests/main.cpp

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D15201: Move logout-greeter into it's own subdir out of ksmserver

2018-09-14 Thread David Edmundson
davidedmundson updated this revision to Diff 41608.
davidedmundson added a comment.


  Update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15201?vs=40813=41608

BRANCH
  dave2

REVISION DETAIL
  https://phabricator.kde.org/D15201

AFFECTED FILES
  CMakeLists.txt
  ksmserver/CMakeLists.txt
  ksmserver/logout-greeter/CMakeLists.txt
  ksmserver/logout-greeter/main.cpp
  ksmserver/logout-greeter/shutdowndlg.cpp
  ksmserver/logout-greeter/shutdowndlg.h
  ksmserver/logout-greeter/tests/CMakeLists.txt
  ksmserver/logout-greeter/tests/main.cpp
  logout-greeter/CMakeLists.txt
  logout-greeter/main.cpp
  logout-greeter/shutdowndlg.cpp
  logout-greeter/shutdowndlg.h
  logout-greeter/tests/CMakeLists.txt
  logout-greeter/tests/config.h.cmake
  logout-greeter/tests/main.cpp

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D15201: Move logout-greeter into it's own subdir out of ksmserver

2018-09-06 Thread Kai Uwe Broulik
broulik requested changes to this revision.
broulik added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:171
>  
> +
>  # This ensures pressing the eject button on a CD drive ejects the disc

Remove

> shutdowndlg.cpp:2
>  /*
> -ksmserver - the KDE session management server
> +LOGOUT_GREETER - the KDE session management server
>  

fix "session management server"
or just remove this line

> CMakeLists.txt:1
> +configure_file(config.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config.h)
> +

This file doesn't exist

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15201

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D15201: Move logout-greeter into it's own subdir out of ksmserver

2018-09-01 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  No code or behavioural changes, just code tidying.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15201

AFFECTED FILES
  CMakeLists.txt
  ksmserver/CMakeLists.txt
  ksmserver/logout-greeter/CMakeLists.txt
  ksmserver/logout-greeter/main.cpp
  ksmserver/logout-greeter/shutdowndlg.cpp
  ksmserver/logout-greeter/shutdowndlg.h
  ksmserver/logout-greeter/tests/CMakeLists.txt
  ksmserver/logout-greeter/tests/main.cpp
  logout-greeter/CMakeLists.txt
  logout-greeter/main.cpp
  logout-greeter/shutdowndlg.cpp
  logout-greeter/shutdowndlg.h
  logout-greeter/tests/CMakeLists.txt
  logout-greeter/tests/main.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart