D15202: Move kcheckrunning into startkde

2018-10-10 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:06bbb92a1730: Move kcheckrunning into startkde (authored 
by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15202?vs=41351=43299#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15202?vs=41351=43299

REVISION DETAIL
  https://phabricator.kde.org/D15202

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/kcheckrunning.cpp
  startkde/CMakeLists.txt
  startkde/kcheckrunning/CMakeLists.txt
  startkde/kcheckrunning/kcheckrunning.cpp

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15202: Move kcheckrunning into startkde

2018-09-10 Thread David Edmundson 
davidedmundson updated this revision to Diff 41351.
davidedmundson added a comment.


  Add missing file

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15202?vs=40814=41351

BRANCH
  dave2

REVISION DETAIL
  https://phabricator.kde.org/D15202

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/kcheckrunning.cpp
  startkde/CMakeLists.txt
  startkde/kcheckrunning/CMakeLists.txt
  startkde/kcheckrunning/kcheckrunning.cpp

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15202: Move kcheckrunning into startkde

2018-09-06 Thread Kai Uwe Broulik 
broulik requested changes to this revision.
broulik added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:88-96
> -set(kcheckrunning_SRCS
> -kcheckrunning.cpp)
> -
> -add_executable( kcheckrunning ${kcheckrunning_SRCS})
> -
> -target_link_libraries(kcheckrunning ${X11_LIBRARIES})
> -target_include_directories(kcheckrunning PRIVATE ${X11_X11_INCLUDE_PATH})

This stuff must go into a `startkde/kcheckrunning/CMakeLists.txt`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15202

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15202: Move kcheckrunning into startkde

2018-09-01 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  kcheckrunning is only used by startkde, it shouldn't be in the ksmserver
  folder.
  
  No code or behavioural changes, just tidying.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  dave2

REVISION DETAIL
  https://phabricator.kde.org/D15202

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/kcheckrunning.cpp
  startkde/CMakeLists.txt
  startkde/kcheckrunning/kcheckrunning.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart