D15304: [KCM] Port (almost) entirely to QQC2

[Nathaniel Graham]

ngraham updated this revision to Diff 49855.
ngraham added a comment.


  Port entirely away from QQC1 by adopting the QQC2 TabBar

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15304?vs=42512=49855

BRANCH
  arcpatch-D15304

REVISION DETAIL
  https://phabricator.kde.org/D15304

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: huftis, nicolasfella, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D15304: [KCM] Port (almost) entirely to QQC2

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham marked an inline comment as done.
ngraham added a comment.


  Scrollviews in the tabs are now broken, investigating.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port (almost) entirely to QQC2

[Nathaniel Graham]

ngraham updated this revision to Diff 42512.
ngraham added a comment.


  - Rebase on master
  - Use Kirigami `Icon` instead of PlasmaCore `IconItem`

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15304?vs=42388=42512

BRANCH
  arcpatch-D15304

REVISION DETAIL
  https://phabricator.kde.org/D15304

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/CardListItem.qml
  src/kcm/package/contents/ui/DeviceComboBox.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port (almost) entirely to QQC2

[David Rosca]

drosca added a comment.


  In D15304#332755 , @ngraham wrote:
  
  > > Plasma items should not be used in KCM.
  >
  > Hmm, what you you recommend then for showing an icon item? The old 
`QIconItem` breaks for fractional scale factors. Kirigami has a nice icon, but 
then we'd need to import Kirigami.
  
  
  I suggest to fix QIconItem, as it is used in other places too.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port (almost) entirely to QQC2

[Nathaniel Graham]

ngraham added a comment.


  > Plasma items should not be used in KCM.
  
  Hmm, what you you recommend then for showing an icon item? The old 
`QIconItem` breaks for fractional scale factors. Kirigami has a nice icon, but 
then we'd need to import Kirigami.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port (almost) entirely to QQC2

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> CardListItem.qml:33
>  RowLayout {
> -QIconItem {
> +PlasmaCore.IconItem {
>  id: clientIcon

Plasma items should not be used in KCM.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port (almost) entirely to QQC2

[Nathaniel Graham]

ngraham updated this revision to Diff 42388.
ngraham added a comment.


  Use QQC2 `ScrollView` and PlasmaCore `iconItem`

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15304?vs=42329=42388

BRANCH
  arcpatch-D15304

REVISION DETAIL
  https://phabricator.kde.org/D15304

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/CardListItem.qml
  src/kcm/package/contents/ui/DeviceComboBox.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port (almost) entirely to QQC2

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  In D15304#332274 , @drosca wrote:
  
  > There is `ScrollView` in QQC2 (since Qt 5.9), so please use it.
  
  
  Ah, I see now that it's only available in QQC 2.2 and later. Will do.
  
  > Also as @davidedmundson said, please edit the commit message.
  
  The commit message from from the patch title, which is now `[KCM] Port 
(almost) entirely to QQC2`. Does that still need adjustment?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15304: [KCM] Port (almost) entirely to QQC2

[David Rosca]

drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  There is `ScrollView` in QQC2 (since Qt 5.9), so please use it.
  Also as @davidedmundson said, please edit the commit message.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: nicolasfella, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart