D15311: [Media Player] Change int to double for positions

2018-09-06 Thread Arsen Arsen 
arsenarsen created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arsenarsen requested review of this revision.

REVISION SUMMARY
  In previous versions of Plasma, media player had an overflow bug in 
positions, leading to the player resetting to 00:00.
  This only affects files longer than around 33 minutes 20 seconds.
  
  BUG: 397591

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15311

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: arsenarsen
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15311: [Media Player] Change int to double for positions

2018-09-06 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks! I will commit this on your behalf if you don't mind.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15311

To: arsenarsen, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15311: [Media Player] Change int to double for positions

2018-09-06 Thread Arsen Arsen 
arsenarsen added a comment.


  Go ahead.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15311

To: arsenarsen, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15311: [Media Player] Change int to double for positions

2018-09-06 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1bb02b98cfed: [Media Player] Change int to double for 
positions (authored by arsenarsen, committed by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15311?vs=41086&id=41088#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15311?vs=41086&id=41088

REVISION DETAIL
  https://phabricator.kde.org/D15311

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: arsenarsen, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart