D15717: Fix spelling errors

2018-09-23 Thread Boris Pek 
borispek created this revision.
borispek added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
borispek requested review of this revision.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D15717

AFFECTED FILES
  src/fontshelpers.cpp
  src/thread.cpp

To: borispek, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15717: Fix spelling errors

2018-09-23 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Whoops! Thanks for fixing those.
  
  I'd like to land this for you, but to do it, I'll need to know your real name 
and email address. Can you provide that information? Thanks!

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D15717

To: borispek, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15717: Fix spelling errors

2018-09-23 Thread Boris Pek 
borispek added a comment.


  Hi,
  
  > I'll need to know your real name and email address. Can you provide that 
information?
  
  Boris Pek 
  
  I supposed that all necessary information was in the patch prepared using 
`git format-patch ...`. It looks I have missed something in phabricator 
documentation. (This is my first patch to KDE after a huge break...)

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D15717

To: borispek, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15717: Fix spelling errors

2018-09-23 Thread Nathaniel Graham 
ngraham added a comment.


  In D15717#330804 , @borispek wrote:
  
  > Hi,
  >
  > > I'll need to know your real name and email address. Can you provide that 
information?
  >
  > Boris Pek 
  >
  > I supposed that all necessary information was in the patch prepared using 
`git format-patch ...`. It looks I have missed something in phabricator 
documentation. (This is my first patch to KDE after a huge break...)
  
  
  Sadly not, just yet; right now we only get that automatically if you use the 
`arc` command-line tool to create the patch. See 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist
  
  It's good to have you back!

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D15717

To: borispek, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15717: Fix spelling errors

2018-09-23 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:d3c6da59f723: Fix spelling errors (authored by borispek, 
committed by ngraham).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15717?vs=42205&id=42206

REVISION DETAIL
  https://phabricator.kde.org/D15717

AFFECTED FILES
  src/fontshelpers.cpp
  src/thread.cpp

To: borispek, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15717: Fix spelling errors

2018-09-23 Thread Nathaniel Graham 
ngraham added a comment.


  Landed on master, so the change will show up in KDE Plasma 5.15. See 
https://community.kde.org/Schedules/Plasma_5 for more information.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D15717

To: borispek, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15717: Fix spelling errors

2018-09-23 Thread Boris Pek 
borispek added a comment.


  Thank you!

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D15717

To: borispek, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15717: Fix spelling errors

2018-09-24 Thread Rik Mills 
rikmills added a comment.


  In D15717#330808 , @ngraham wrote:
  
  > Landed on master, so the change will show up in KDE Plasma 5.15. See 
https://community.kde.org/Schedules/Plasma_5 for more information.
  
  
  Why not in 5.14 which also has these errors?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D15717

To: borispek, ngraham
Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15717: Fix spelling errors

2018-09-24 Thread Nathaniel Graham 
ngraham added a comment.


  Because it has a string change, but I realize now that this doesn't actually 
preclude going into 5.14 since it's not a translated string. I'll cherry-pick 
it onto 5.14, and thanks for following up on this @rikmills!

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D15717

To: borispek, ngraham
Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15717: Fix spelling errors

2018-09-24 Thread Nathaniel Graham 
ngraham added a comment.


  Cherry-picked onto the `Plasma/5.14` branch now.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D15717

To: borispek, ngraham
Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart