D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6a4f4cc31ebc: [Folder View] Improve layout, formatting, 
and wording of Icons and Locations… (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16241?vs=44089&id=44679

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/ConfigLocation.qml

To: ngraham, #plasma, #vdg, hein, mart
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

[Eike Hein]

hein accepted this revision.
hein added a comment.


  Looks great, I'm happy to finally see this get cleaned up.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein, mart
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

[Nathaniel Graham]

ngraham added a comment.


  @mart? Anyone in #plasma ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein, mart
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

[Nathaniel Graham]

ngraham added a comment.


  @mart?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein, mart
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

[Nathaniel Graham]

ngraham added a comment.


  @mart I've implemented your suggestions. To my eyes, the vertical spacing 
isn't enough. Compare the current version: F6344159: Using the correct 
objects.png 
  
  ...With the previous one I had before: F6339576: Desktop icons after.png 

  
  But that's pretty minor and would need to be changed (if you agree) elsewhere.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein, mart
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

[Nathaniel Graham]

ngraham updated this revision to Diff 44089.
ngraham added a comment.


  Implement @mart's suggestions

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16241?vs=43959&id=44089

BRANCH
  icons-page-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16241

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/ConfigLocation.qml

To: ngraham, #plasma, #vdg, hein, mart
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ConfigIcons.qml:130
>  
> -// Row 1: Spacing
> -Item {
> -Layout.row: 1
> -Layout.column: 0
> -Layout.minimumHeight: units.largeSpacing
> +Kirigami.Spacer {
>  visible: isPopup

those should be just

Item {
Kirigami.FormData.isSection: true
}

then, we'll see how things in formlayout have to be fixed to reach the desired 
spacing/result

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D16241

To: ngraham, #plasma, #vdg, hein, mart
Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol