D16269: Show correct current download and upload speed

[Alexander Volkov]

volkov added a comment.


  The problem with this change is that speed is shown in bytes, not in bytes/s.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D16269

To: jgrulich, #plasma, broulik
Cc: volkov, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16269: Show correct current download and upload speed

[Jan Grulich]

jgrulich added a comment.


  In D16269#370817 , @volkov wrote:
  
  > I mentioned in D14835  that the total 
number of received/transmitted bytes is more useful than  the current speed.
  >  One can see the current speed on the graph.
  
  
  Oh, sorry for that, I most probably didn't notice this change and assumed 
it's a bug, because I was checking current speed and was wondering why it shows 
such big numbers. It's hard to say which information is more useful, I would 
personally leave the current upload/download to be there and put the total 
download/upload into the details section or under the graph as it used to be 
with the old networkmanagement applet.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D16269

To: jgrulich, #plasma, broulik
Cc: volkov, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16269: Show correct current download and upload speed

[Alexander Volkov]

volkov added a comment.


  I mentioned in D14835  that the total 
number of received/transmitted bytes is more useful than  the current speed.
  One can see the current speed on the graph.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D16269

To: jgrulich, #plasma, broulik
Cc: volkov, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16269: Show correct current download and upload speed

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:c5593b02df38: Show correct current download and upload 
speed (authored by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16269?vs=43781=43782

REVISION DETAIL
  https://phabricator.kde.org/D16269

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  libs/models/networkmodel.cpp

To: jgrulich, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16269: Show correct current download and upload speed

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  After recent change to use NM::DeviceStatistics instead of plasma dataengine, 
this part
  of code wasn't changed and instead of showing current download/upload speed, 
it was
  showing total downloaded/uploaded size

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D16269

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  libs/models/networkmodel.cpp

To: jgrulich
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart