D16417: Improve replacement text when action description is not provided

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R121:9cf71f424950: Improve replacement text when action 
description is not provided (authored by bruns).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16417?vs=44183&id=44205

REVISION DETAIL
  https://phabricator.kde.org/D16417

AFFECTED FILES
  AuthDialog.cpp

To: bruns, #plasma, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16417: Improve replacement text when action description is not provided

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, this works.

INLINE COMMENTS

> bruns wrote in AuthDialog.cpp:359
> Btw, "not provided" is your own proposal ;-)

What!? I must be going senile already...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D16417

To: bruns, #plasma, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16417: Improve replacement text when action description is not provided

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in AuthDialog.cpp:359
> I would prefer "not available" over "not provided", but I won't choose this 
> as my hill to die on. :)
> 
> Do we actually need to repeat the word 'Description' here?

Btw, "not provided" is your own proposal ;-)

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D16417

To: bruns, #plasma, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16417: Improve replacement text when action description is not provided

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in AuthDialog.cpp:356
> So I gather `.isEmpty()` works now?

Yes.

> ngraham wrote in AuthDialog.cpp:359
> I would prefer "not available" over "not provided", but I won't choose this 
> as my hill to die on. :)
> 
> Do we actually need to repeat the word 'Description' here?

There is no repetition here - the Polkit "" is labeled "Action:" 
in the dialog.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D16417

To: bruns, #plasma, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16417: Improve replacement text when action description is not provided

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> AuthDialog.cpp:356
> -// replace blank description
> -// neither isEmpty() or isNull() worked (?)
> -if (actionDescription.description() == "") {

So I gather `.isEmpty()` works now?

> AuthDialog.cpp:359
>  action_label->setFont(descrFont);
> -action_label->setText(i18n("Not Applicable"));
> +action_label->setText(i18n("'Description' not provided"));
>  } else {

I would prefer "not available" over "not provided", but I won't choose this as 
my hill to die on. :)

Do we actually need to repeat the word 'Description' here?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D16417

To: bruns, #plasma, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16417: Improve replacement text when action description is not provided

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Plasma, ngraham, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The polkit rules specification mandates a description for actions,
  
https://www.freedesktop.org/software/polkit/docs/latest/polkit.8.html#polkit-declaring-actions
  
  Split from D12498 .

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D16417

AFFECTED FILES
  AuthDialog.cpp

To: bruns, #plasma, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart