D16587: [ksmserver] Simplify call to kcminit

2018-11-01 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
davidedmundson marked an inline comment as done.
Closed by commit R120:8c85bfa65a11: [ksmserver] Simplify call to kcminit 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16587?vs=44630&id=44681

REVISION DETAIL
  https://phabricator.kde.org/D16587

AFFECTED FILES
  ksmserver/startup.cpp
  ksmserver/startup.h
  startkde/kcminit/main.cpp
  startkde/kcminit/main.h

To: davidedmundson, #plasma, broulik
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16587: [ksmserver] Simplify call to kcminit

2018-11-01 Thread David Edmundson 
davidedmundson updated this revision to Diff 44630.
davidedmundson added a comment.


  remove Q_SIGNALS

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16587?vs=44628&id=44630

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16587

AFFECTED FILES
  ksmserver/startup.cpp
  ksmserver/startup.h
  startkde/kcminit/main.cpp
  startkde/kcminit/main.h

To: davidedmundson, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16587: [ksmserver] Simplify call to kcminit

2018-11-01 Thread Vlad Zagorodniy 
zzag added inline comments.

INLINE COMMENTS

> main.h:37
>  Q_SCRIPTABLE void runPhase2();
> -Q_SIGNALS: //dbus signal
> - Q_SCRIPTABLE void phase1Done();
> - Q_SCRIPTABLE void phase2Done();
> +Q_SIGNALS:
>  public:

It looks like there are no more signals anymore. Do we need Q_SIGNALS?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16587

To: davidedmundson, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16587: [ksmserver] Simplify call to kcminit

2018-11-01 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  kcminit had a slot to start processing something and a signal to emit
  when it's finished.
  
  For DBus that's quite bad practice as it can leave you hanging in the
  case of a kcminit crashing. It's better to use the return of the
  original call to signal when something is done.
  
  From ksmserver we can then just use DBus timeouts set on the interface
  than a secondary timer.
  
  We also remove a pointless blocking call to kcminit introspecting
  everything, if kcminit is not running it will return with an error
  immediately which is no slower than checking first if it's not running
  and faster if it is.

TEST PLAN
  Logged in
  Session logs showed kcminit ran

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16587

AFFECTED FILES
  ksmserver/startup.cpp
  ksmserver/startup.h
  startkde/kcminit/main.cpp
  startkde/kcminit/main.h

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart