D16886: [windowswitcher] Implement keyboard navigation

2019-02-18 Thread Nathaniel Graham 
ngraham added a comment.


  Yes, that one already works in Plasma 5.15. All of them should now work with 
keyboard navigation, in fact.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16886

To: ngraham, #plasma, graesslin
Cc: abetts, szafar, davidedmundson, Zren, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D16886: [windowswitcher] Implement keyboard navigation

2019-02-17 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16886

To: ngraham, #plasma, graesslin
Cc: abetts, szafar, davidedmundson, Zren, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D16886: [windowswitcher] Implement keyboard navigation

2019-02-17 Thread Shadab Zafar 
szafar added a comment.


  Is there a similar feature for the "Large Icons" switcher? Using Left/Right 
arrow keys there would make a lot of sense.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16886

To: ngraham, #plasma, graesslin
Cc: szafar, davidedmundson, Zren, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16886: [windowswitcher] Implement keyboard navigation

2018-11-15 Thread David Edmundson 
davidedmundson added subscribers: Zren, davidedmundson.
davidedmundson added a comment.


  In the previous patch @zren said:
  
  > "Breeze (Look and Feel)
  > 
  >   Works?! I guess the ListView handles the key input?"
  
  and the comments in this patch are copy pasted from the kdeplasma-addons ones 
from back when we needed the hack.
  
  Are you sure it's needed?
  /If/ focus is wrong, then we're going to have a problem with the 
accessibility reader that needs fixing regardless.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16886

To: ngraham, #plasma, graesslin
Cc: davidedmundson, Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16886: [windowswitcher] Implement keyboard navigation

2018-11-15 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4d52641657d6: [windowswitcher] Implement keyboard 
navigation (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16886?vs=45493=45517

REVISION DETAIL
  https://phabricator.kde.org/D16886

AFFECTED FILES
  lookandfeel/contents/windowswitcher/WindowSwitcher.qml

To: ngraham, #plasma, graesslin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16886: [windowswitcher] Implement keyboard navigation

2018-11-14 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Implements keyboard navigation via the up and down arrow keys for the Breeze 
window switcher.
  
  CCBUG: 370185

TEST PLAN
  Alt-tab, use arrow keys, it works!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  breeze-window-switcher-keyboard-navigation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16886

AFFECTED FILES
  lookandfeel/contents/windowswitcher/WindowSwitcher.qml

To: ngraham, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart