D16898: [kcm] Remove profiles code
This revision was automatically updated to reflect the committed changes. Closed by commit R104:7283fb5630df: [kcm] Remove profiles code (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16898?vs=45519&id=57748 REVISION DETAIL https://phabricator.kde.org/D16898 AFFECTED FILES kcm/src/profilesmodel.cpp kcm/src/profilesmodel.h kcm/src/widget.cpp kcm/src/widget.h To: romangg, #plasma, apol, davidedmundson Cc: davidedmundson, afiestas, apol, dvratil, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D16898: [kcm] Remove profiles code
davidedmundson accepted this revision. davidedmundson added a comment. I remember Alex at the time had a thing that new features should be in master but in #ifdefs so it's easier for other devs to test things than having a giant patchset that no-one can even find and have to keep switching between. It's not a bad idea, I never run code in branches for a long time. However, it doesn't work if things get abandoned and die. REPOSITORY R104 KScreen BRANCH removeProfilesCode REVISION DETAIL https://phabricator.kde.org/D16898 To: romangg, #plasma, apol, davidedmundson Cc: davidedmundson, afiestas, apol, dvratil, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D16898: [kcm] Remove profiles code
dvratil added a subscriber: afiestas. dvratil added a comment. Profiles were supposed to allow various screen layouts per single setup, for instance, if you have your monitor and TV both connected to your PC, you may want to have "Monitor", "Monitor+TV" and "TV-only" profiles. The idea was to have a combobox in the KCM that would allow you to quickly switch between those profiles without having to fiddle with the rest of the GUI every time. IIRC we did not agree with @afiestas on this feature back then, so it remained disabled (should've been on a branch instead of #ifdefs on master, I admit that ) and while I was still working on kscreen, I never got around to actually finish it and push it. REPOSITORY R104 KScreen BRANCH removeProfilesCode REVISION DETAIL https://phabricator.kde.org/D16898 To: romangg, #plasma, apol Cc: afiestas, apol, dvratil, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D16898: [kcm] Remove profiles code
apol added subscribers: dvratil, apol. apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. RIP I see that @dvratil removed it at some point, maybe he remembers why it's not necessary? REPOSITORY R104 KScreen BRANCH removeProfilesCode REVISION DETAIL https://phabricator.kde.org/D16898 To: romangg, #plasma, apol Cc: apol, dvratil, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
D16898: [kcm] Remove profiles code
romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This code seems to be unused for a long time or was never used at all. Introduced in 2013 there were no substantial commits to it afterwards, nor is the functionality exposed to the Ui. TEST PLAN Compiles. REPOSITORY R104 KScreen BRANCH removeProfilesCode REVISION DETAIL https://phabricator.kde.org/D16898 AFFECTED FILES kcm/src/profilesmodel.cpp kcm/src/profilesmodel.h kcm/src/widget.cpp kcm/src/widget.h To: romangg, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
