D17212: Port to QQC2 and FormLayout

2018-12-03 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:76eba93be27f: Port to QQC2 and FormLayout (authored by 
mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17212?vs=46465&id=46770

REVISION DETAIL
  https://phabricator.kde.org/D17212

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigGeneral.qml
  wallpapers/image/imagepackage/contents/ui/config.qml

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

2018-11-29 Thread Marco Martin 
mart added a comment.


  In D17212#368135 , @abetts wrote:
  
  > In D17212#368048 , @mart wrote:
  >
  > > F6446445: Screenshot_20181129_143041.png 

  >
  >
  > Wait! Isn't the header labels supposed to be on the right? They are also 
supposed to be aligned to the first item in the series of checkboxes.
  
  
  no
  
  > Current:
  > 
  > LABEL
  > 
  > [X] ITEM
  > 
  >   Proper:
  > 
  >   LABEL [x] ITEM
  
  no, formalyout titles are titles on top of the section.
  They used to always be left aligned, but after a long discussion they were 
moved towards the center as well.
  This is the reference implementation of a correct form layout in the kirigami 
gallery:
  
  F6447089: Screenshot_20181129_170219.png 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

2018-11-29 Thread Nathaniel Graham 
ngraham added a comment.


  That's true, in this case where not one of the items has a left label, we 
generally like to use left labels as pseudo section headers, like in Dolphin's 
settings window.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

2018-11-29 Thread Andres Betts 
abetts added a comment.


  In D17212#368048 , @mart wrote:
  
  > F6446445: Screenshot_20181129_143041.png 

  
  
  Wait! Isn't the header labels supposed to be on the right? They are also 
supposed to be aligned to the first item in the series of checkboxes.
  
  Current:
  
  LABEL
  
  [X] ITEM
  
  Proper:
  
  LABEL [x] ITEM

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

2018-11-29 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Lovely :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

2018-11-29 Thread Marco Martin 
mart updated this revision to Diff 46465.
mart added a comment.


  - center the layout

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17212?vs=46396&id=46465

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17212

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigGeneral.qml
  wallpapers/image/imagepackage/contents/ui/config.qml

To: mart, #plasma, #vdg
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

2018-11-29 Thread Marco Martin 
mart added a comment.


  F6446445: Screenshot_20181129_143041.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

2018-11-28 Thread Nathaniel Graham 
ngraham added a comment.


  Looking good code-wise!
  
  Could we take the opportunity to improve the layout too? This huge list of 
checkboxes is entirely left-aligned, with a huge gaping chasm of whitespace on 
the right. Seems like we could benefit from centering it as per the typical 
Kirigami FormLayout appearance.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

2018-11-28 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

2018-11-28 Thread Marco Martin 
mart added a comment.


  F6444563: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

2018-11-28 Thread Marco Martin 
mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  No big visible changes, but simplifies and modernizes the code

TEST PLAN
  used all functionality of the systray config dialog

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17212

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigGeneral.qml

To: mart, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart