D17365: Round folder view delegate and label positions

2018-12-05 Thread Fabian Vogt 
fvogt updated this revision to Diff 46884.
fvogt added a comment.


  Turns out the label width rounding is enough

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17365?vs=46882=46884

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17365

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: fvogt, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17365: Round folder view delegate and label positions

2018-12-05 Thread Fabian Vogt 
fvogt added inline comments.

INLINE COMMENTS

> broulik wrote in FolderItemDelegate.qml:66
> That's what this hideous code is actually supposed to do

It doesn't work though - I'll check some more.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17365

To: fvogt, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17365: Round folder view delegate and label positions

2018-12-05 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> FolderItemDelegate.qml:66
>  // leading to blurry rendering. The Loader is offset to account for 
> this.
>  x: -main.x % 1
>  y: -main.y % 1

That's what this hideous code is actually supposed to do

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17365

To: fvogt, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17365: Round folder view delegate and label positions

2018-12-05 Thread Fabian Vogt 
fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  Currently the delegates and especially the labels can be at non-integer
  positions. This results in ugly font rendering.

TEST PLAN
  Before/after: https://phabricator.kde.org/F6456830

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17365

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml
  containments/desktop/package/contents/ui/FolderView.qml

To: fvogt, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart