D17365: Round label width

2018-12-05 Thread Fabian Vogt 
fvogt added a comment.


  > Hmm, the "After" pictured depicts terrible kerning. Take a look at 
"Discover" in particular. Is this really the trade-off we're faced with? It 
feels like there are upstream Qt bugs here.
  
  Yup, definitely. Font rendering in QML has some issues.
  
  FreeType hinting configuration and especially the used font can make a huge 
difference though. With "Roboto" for example it looks perfectly fine.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17365

To: fvogt, #plasma, broulik
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17365: Round label width

2018-12-05 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, the "After" pictured depicts terrible kerning. Take a look at "Discover" 
in particular. Is this really the trade-off we're faced with? It feels like 
there are upstream Qt bugs here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17365

To: fvogt, #plasma, broulik
Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17365: Round label width

2018-12-05 Thread Fabian Vogt 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3526334e8234: Round label width (authored by fvogt).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17365?vs=46884=46886

REVISION DETAIL
  https://phabricator.kde.org/D17365

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: fvogt, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17365: Round label width

2018-12-05 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Cool! Stable branch pls

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17365

To: fvogt, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart