D17659: Set parent window for dialogs

2018-12-18 Thread Alexander Volkov 
volkov created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
volkov requested review of this revision.

REVISION SUMMARY
  This requires fix in Qt to work for standard dialogs:
  https://codereview.qt-project.org/#/c/248559/

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D17659

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/access.cpp
  src/appchooser.cpp
  src/filechooser.cpp
  src/print.cpp
  src/screencast.cpp
  src/screenshot.cpp
  src/utils.cpp
  src/utils.h

To: volkov
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17659: Set parent window for dialogs

2018-12-18 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM, I also missed this!
  
  Maybe it would make sense to add a TODO about implementing it for Wayland?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D17659

To: volkov, jgrulich, apol
Cc: apol, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D17659: Set parent window for dialogs

2018-12-18 Thread Aleix Pol Gonzalez 
apol added a comment.


  We can backport the patch to the runtime when it gets accepted, so we'll have 
all it takes.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D17659

To: volkov, jgrulich, apol
Cc: apol, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D17659: Set parent window for dialogs

2018-12-19 Thread Kai Uwe Broulik 
broulik added a comment.


  +1

INLINE COMMENTS

> utils.h:24
> +
> +class Utils
> +{

This might as well be a `namespace`?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D17659

To: volkov, jgrulich, apol
Cc: broulik, apol, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D17659: Set parent window for dialogs

2018-12-19 Thread Martin Flöser 
graesslin added a comment.


  In D17659#379007 , @apol wrote:
  
  > LGTM, I also missed this!
  >
  > Maybe it would make sense to add a TODO about implementing it for Wayland?
  
  
  Even better would be to just implement it for Wayland. 
https://api.kde.org/frameworks/kwayland/html/classKWayland_1_1Client_1_1XdgExporter.html
 and 
https://api.kde.org/frameworks/kwayland/html/classKWayland_1_1Client_1_1XdgImporter.html
 are the relevant classes.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D17659

To: volkov, jgrulich, apol
Cc: graesslin, broulik, apol, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D17659: Set parent window for dialogs

2018-12-20 Thread Alexander Volkov 
volkov added a comment.


  Is it possible to implement support for foreign windows in KWin QPA plugin?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  Plasma/5.14

REVISION DETAIL
  https://phabricator.kde.org/D17659

To: volkov, jgrulich, apol
Cc: graesslin, broulik, apol, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D17659: Set parent window for dialogs

2018-12-25 Thread Alexander Volkov 
volkov closed this revision.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17659

To: volkov, jgrulich, apol
Cc: graesslin, broulik, apol, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D17659: Set parent window for dialogs

2018-12-26 Thread Martin Flöser 
graesslin added a comment.


  In D17659#379912 , @volkov wrote:
  
  > Is it possible to implement support for foreign windows in KWin QPA plugin?
  
  
  There is no such thing as a KWin QPA.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17659

To: volkov, jgrulich, apol
Cc: graesslin, broulik, apol, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D17659: Set parent window for dialogs

2019-01-09 Thread Alexander Volkov 
volkov added a comment.


  I mean this plugin: https://cgit.kde.org/kwin.git/tree/plugins/qpa

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17659

To: volkov, jgrulich, apol
Cc: graesslin, broulik, apol, plasma-devel, kvanton, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D17659: Set parent window for dialogs

2019-01-09 Thread Martin Flöser 
graesslin added a comment.


  In D17659#389728 , @volkov wrote:
  
  > I mean this plugin: https://cgit.kde.org/kwin.git/tree/plugins/qpa
  
  
  That is KWin's own plugin. No binary except KWin can use it.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17659

To: volkov, jgrulich, apol
Cc: graesslin, broulik, apol, plasma-devel, kvanton, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D17659: Set parent window for dialogs

2019-01-10 Thread Alexander Volkov 
volkov added a comment.


  Oh, I see.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17659

To: volkov, jgrulich, apol
Cc: graesslin, broulik, apol, plasma-devel, kvanton, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart