D17960: Added “modeCmdPart” to “redshiftOneTimeCommand”

[David Edmundson]

davidedmundson added a comment.


  Sorry! pushed.
  
  Please do feel free to nag if I forget things.

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17960

To: kvanton, #plasma
Cc: ltoscano, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D17960: Added “modeCmdPart” to “redshiftOneTimeCommand”

[Anton KV]

kvanton added a comment.


  In D17960#386905 , @davidedmundson 
wrote:
  
  > > Sorry, this is my first time. How can I check access to a commit before 
doing it?
  >
  > Congrats on your first patch. I'll sort it out.
  
  
  Of course, I still love and respect you, friend. 
  I still find this feature useful. 
  This allows you to independently adjust the temperature and brightness on 
different monitors. (it's still not possible without redshift)
  Yes, I do not have access to commits

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17960

To: kvanton, #plasma
Cc: ltoscano, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D17960: Added “modeCmdPart” to “redshiftOneTimeCommand”

[Luigi Toscano]

ltoscano added a comment.


  @davidedmundson time to commit? :)
  
  On a related news: I think it would make sense to create a new point release 
for plasma-redshift-control after this patch (there are many translation 
updates). Who could check that everything is in order and create the tarball?

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17960

To: kvanton, #plasma
Cc: ltoscano, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17960: Added “modeCmdPart” to “redshiftOneTimeCommand”

[David Edmundson]

davidedmundson added a comment.


  > Sorry, this is my first time. How can I check access to a commit before 
doing it?
  
  Congrats on your first patch. I'll sort it out.

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17960

To: kvanton, #plasma
Cc: davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17960: Added “modeCmdPart” to “redshiftOneTimeCommand”

[Anton KV]

kvanton added a comment.


  In D17960#386323 , @davidedmundson 
wrote:
  
  > Seems sensible. I don't maintain the stuff in playground, but no-one really 
does.
  >
  > If there's no comment in a week, ship it!
  >
  > Do you have commit access?
  
  
  Sorry, this is my first time. How can I check access to a commit before doing 
it?

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17960

To: kvanton, #plasma
Cc: davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17960: Added “modeCmdPart” to “redshiftOneTimeCommand”

[David Edmundson]

davidedmundson added a comment.


  Seems sensible. I don't maintain the stuff in playground, but no-one really 
does.
  
  If there's no comment in a week, ship it!
  
  Do you have commit access?

REPOSITORY
  R885 Redshift Control for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D17960

To: kvanton, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17960: Added “modeCmdPart” to “redshiftOneTimeCommand”.This is necessary for use the custom mode options “renderMode” when manually changing the Brightness and Temperature.This is important, for exam

[Anton KV]

kvanton created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kvanton requested review of this revision.

REVISION SUMMARY
  Manual adjust Brightness and/or Temperature using custom mode options 
(redshift -m METHOD...)

REPOSITORY
  R885 Redshift Control for Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17960

AFFECTED FILES
  package/contents/ui/main.qml

To: kvanton
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart