D18206: Improve the Look and Feel KCM

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:beca304a1f44: Improve the Look and Feel KCM (authored by 
GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18206?vs=49321=49374

REVISION DETAIL
  https://phabricator.kde.org/D18206

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/lookandfeel/package/metadata.desktop

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, rooty, rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18206: Improve the Look and Feel KCM

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1
  
  I think the use of an article is okay here since it's basically a tooltip 
that just happens to be inappropriately displayed as a title for other reasons.
  
  All those +1s add up to a formal acceptance, methinks.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-lookandfeel-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18206

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, rooty, rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma, 
kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18206: Improve the Look and Feel KCM

[Root]

rooty added a comment.


  +1 from me
  if you want you could drop the article by the way and make it "Choose Look 
and Feel theme"
  it's like "Configure Network Settings" vs "Configure the Network Settings"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18206

To: GB_2, #plasma, #vdg
Cc: rooty, rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma, kvanton, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18206: Improve the Look and Feel KCM

[Chris Rizzitello]

rizzitello added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18206

To: GB_2, #plasma, #vdg
Cc: rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D18206: Improve the Look and Feel KCM

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18206

To: GB_2, #plasma, #vdg
Cc: abetts, filipf, #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18206: Improve the Look and Feel KCM

[Filip Fila]

filipf added a comment.


  I like this because the essence of what the user is doing in this kcm is 
choosing, rather than configuring.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18206

To: GB_2, #plasma, #vdg
Cc: filipf, #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18206: Improve the Look and Feel KCM

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  The LnF KCM has some inconsistencies and doesn't always apply the KDE HIG, so 
this fixes that and makes some other improvements.
  F6546516: LnF KCM.png 

TEST PLAN
  Open the LnF KCM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-lookandfeel-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18206

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/lookandfeel/package/metadata.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart