D18247: Improve Desktop/Plasma Theme KCM

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2015bad98e64: Improve Desktop/Plasma Theme KCM (authored 
by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18247?vs=49453=49461

REVISION DETAIL
  https://phabricator.kde.org/D18247

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/metadata.desktop

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, sukalyanbanga, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18247: Improve Desktop/Plasma Theme KCM

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1. The only change here that I think might be  remotely controversial is 
changing "Desktop theme" to Plasma theme". But I thin that's a very good change 
since it improves the ability to understand what this actually is, and also 
uses our branding. You're using Plasma, so this thing chooses the Plasma theme. 
Makes sense to me.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-desktoptheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18247

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, sukalyanbanga, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18247: Improve Desktop/Plasma Theme KCM

[Björn Feber]

GB_2 added a comment.


  In D18247#393021 , @davidedmundson 
wrote:
  
  > > The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always 
apply the KDE HIG, so this fixes it, makes some other improvements and
  >
  > Where?
  >
  > > renames the KCM to "Plasma Theme".
  >
  > I can only see this.
  
  
  Wrong description, icon and text capitalization.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18247

To: GB_2, #plasma, #vdg
Cc: davidedmundson, #vdg, plasma-devel, #plasma, sukalyanbanga, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18247: Improve Desktop/Plasma Theme KCM

[David Edmundson]

davidedmundson added a comment.


  > The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always 
apply the KDE HIG, so this fixes it, makes some other improvements and
  
  Where?
  
  > renames the KCM to "Plasma Theme".
  
  I can only see this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18247

To: GB_2, #plasma, #vdg
Cc: davidedmundson, #vdg, plasma-devel, #plasma, sukalyanbanga, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18247: Improve Desktop/Plasma Theme KCM

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Similar to D18206 .
  The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always 
apply the KDE HIG, so this fixes it, makes some other improvements and renames 
the KCM to "Plasma Theme".

TEST PLAN
  Open the Desktop/Plasma Theme KCM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-desktoptheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18247

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/metadata.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart