D18267: Improve the Cursor Theme KCM

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e0a4d3fa415d: Improve the Cursor Theme KCM (authored by 
GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18267?vs=49536&id=49540

REVISION DETAIL
  https://phabricator.kde.org/D18267

AFFECTED FILES
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/cursortheme/package/metadata.desktop

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18267: Improve the Cursor Theme KCM

[Björn Feber]

GB_2 added a comment.


  In D18267#393635 , @ngraham wrote:
  
  > In D18267#393620 , 
@davidedmundson wrote:
  >
  > > > In the tooltip and header on the page
  > >
  > >
  > >
  > > > In the description of the KCM when you hover over it.
  > >
  > > Both those are taken from kcm_cursortheme.desktop surely.
  >
  >
  > Yeah, but if we change it there, we should make sure that 
`metadata.desktop` is updated too, right?
  
  
  Yes, this also wasn't a problem with the other patches.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-cursortheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18267

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18267: Improve the Cursor Theme KCM

[Nathaniel Graham]

ngraham added a comment.


  In D18267#393620 , @davidedmundson 
wrote:
  
  > > In the tooltip and header on the page
  >
  >
  >
  > > In the description of the KCM when you hover over it.
  >
  > Both those are taken from kcm_cursortheme.desktop surely.
  
  
  Yeah, but if we change it there, we should make sure that `metadata.desktop` 
is updated too, right?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-cursortheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18267

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18267: Improve the Cursor Theme KCM

[David Edmundson]

davidedmundson added a comment.


  > In the tooltip and header on the page
  
  
  
  > In the description of the KCM when you hover over it.
  
  Both those are taken from kcm_cursortheme.desktop surely.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-cursortheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18267

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18267: Improve the Cursor Theme KCM

[Björn Feber]

GB_2 added a comment.


  In D18267#393604 , @davidedmundson 
wrote:
  
  > Try to stick to titles that aren't "improve" as that literally covers every 
patch (or at least, you'd hope so)
  
  
  Ok, there is one more patch that I will make with this name though, since I 
already used this name and description for the other ones too.

INLINE COMMENTS

> davidedmundson wrote in metadata.desktop:63
> Where is this string visible?

In the description of the KCM when you hover over it.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-cursortheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18267

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18267: Improve the Cursor Theme KCM

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> davidedmundson wrote in metadata.desktop:63
> Where is this string visible?

In the tooltip and header on the page. Or at least, this should be consistent 
with the `Comment` in `kcm_cursortheme.desktop`.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-cursortheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18267

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18267: Improve the Cursor Theme KCM

[David Edmundson]

davidedmundson added a comment.


  Try to stick to titles that aren't "improve" as that literally covers every 
patch (or at least, you'd hope so)

INLINE COMMENTS

> metadata.desktop:63
>  Name[zh_TW]=游標主題
> -Comment=Mouse Cursor Theme
> +Comment=Choose the mouse cursor theme
>  Comment[ar]=سمة مؤشّر الفأرة

Where is this string visible?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18267

To: GB_2, #plasma, #vdg
Cc: davidedmundson, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18267: Improve the Cursor Theme KCM

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  The Cursor Theme KCM has some inconsistencies and doesn't always apply the 
KDE HIG, so this fixes it and makes some other improvements.

TEST PLAN
  Open the Cursor Theme KCM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-cursortheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18267

AFFECTED FILES
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/cursortheme/package/metadata.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart