D18309: don't set python exe to undefined

2019-01-17 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R98:51e27ecf4057: don't set python exe to undefined 
(authored by sitter).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18309?vs=49691&id=49700

REVISION DETAIL
  https://phabricator.kde.org/D18309

AFFECTED FILES
  cmake/FindPythonCairo.cmake

To: sitter, davidedmundson, fvogt
Cc: fvogt, heikobecker, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18309: don't set python exe to undefined

2019-01-17 Thread Fabian Vogt 
fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Tested with cmake 3.10.2, works.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18309

To: sitter, davidedmundson, fvogt
Cc: fvogt, heikobecker, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18309: don't set python exe to undefined

2019-01-16 Thread Heiko Becker 
heikobecker added a comment.


  +1
  I have no cmake < 3.12.0 to test, but the changes are reasonable.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18309

To: sitter, davidedmundson
Cc: heikobecker, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18309: don't set python exe to undefined

2019-01-16 Thread Harald Sitter 
sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  FindPythonInterp sets PYTHON_EXECUTABLE, we overrode it by setting an
  empty var. add a comment to explain the unbalancedness of the conditional
  branches.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18309

AFFECTED FILES
  cmake/FindPythonCairo.cmake

To: sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart