D18314: Cosmetic fixes for build_theme.sh
ngraham added a comment. lol too fast for me REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18314 To: gepardo, davidedmundson Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18314: Cosmetic fixes for build_theme.sh
ngraham added a comment. @davidedmundson should we land this to the 5.15 branch, or just master? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18314 To: gepardo, davidedmundson Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18314: Cosmetic fixes for build_theme.sh
This revision was automatically updated to reflect the committed changes. Closed by commit R98:6a6a432546bb: Cosmetic fixes for build_theme.sh (authored by gepardo, committed by davidedmundson). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18314?vs=49704&id=49759 REVISION DETAIL https://phabricator.kde.org/D18314 AFFECTED FILES src/build_theme.sh To: gepardo, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18314: Cosmetic fixes for build_theme.sh
gepardo added a comment. @davidedmundson, can you please merge it into master? I don't have a developer account, so I can't do this by myself. REPOSITORY R98 Breeze for Gtk BRANCH build-script-minor-fixes (branched from master) REVISION DETAIL https://phabricator.kde.org/D18314 To: gepardo, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D18314: Cosmetic fixes for build_theme.sh
gepardo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gepardo requested review of this revision. REVISION SUMMARY I saw the changes introduced by https://phabricator.kde.org/D18287. It's a really good idea :) The commit contains some minor fixes into the build script (like quoting "$4" parameter) TEST PLAN Builds on my machine. The changes are minor and should not affect anything. REPOSITORY R98 Breeze for Gtk BRANCH build-script-minor-fixes (branched from master) REVISION DETAIL https://phabricator.kde.org/D18314 AFFECTED FILES src/build_theme.sh To: gepardo Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
