D18321: support for the concept of expandible items

2019-01-21 Thread Marco Martin 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:2e7602f3fa5f: support for the concept of expandible items 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18321?vs=49721&id=49998#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18321?vs=49721&id=49998

REVISION DETAIL
  https://phabricator.kde.org/D18321

AFFECTED FILES
  kirigami.qrc
  kirigami.qrc.in
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ContextDrawerActionItem.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/templates/OverlayDrawer.qml

To: mart, #kirigami
Cc: alex-l, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18321: support for the concept of expandible items

2019-01-17 Thread Alessandro Longo 
alex-l added a comment.


  Very cool!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18321

To: mart, #kirigami
Cc: alex-l, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18321: support for the concept of expandible items

2019-01-17 Thread Marco Martin 
mart added a comment.


  the Global Drawer Mode section is expanded
  F6553308: Screenshot_20190117_150513.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18321

To: mart, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18321: support for the concept of expandible items

2019-01-17 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  if an Action has the property expandible, its subactions are shown under it 
in globalDrawer 
  and ContextDrawer
  those actions will disappear when the globaldrawer is collapsed.
  useful to have a more hyerarchical looking sidebars

TEST PLAN
  using it in the gallery and in Koko

REPOSITORY
  R169 Kirigami

BRANCH
  mart/expandibleItems

REVISION DETAIL
  https://phabricator.kde.org/D18321

AFFECTED FILES
  kirigami.qrc
  kirigami.qrc.in
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ContextDrawerActionItem.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/templates/OverlayDrawer.qml

To: mart, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein