D18546: [Desktop Toolbox] Use "tools" icon

[Björn Feber]

GB_2 added a comment.


  I think this revision can be abandoned.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: Codezela, GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

[Nathaniel Graham]

ngraham added a comment.


  I've started a Phab task to discuss the issue from a higher level: T10402: 
The Desktop Toolbox .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: Codezela, GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

[Noah Davis]

ndavis added a comment.


  If we are going to change the name, I would suggest changing it to something 
that has a similar meaning to "edit the desktop" and change the icon to 
something that means "edit". That's the primary use for this widget anyway.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: Codezela, GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

[Noah Davis]

ndavis added a comment.


  In D18546#400325 , @Codezela wrote:
  
  > In D18546#400256 , @GB_2 wrote:
  >
  > > In D18546#400253 , @hein wrote:
  > >
  > > > How about we actually rename it "Desktop Menu".
  > >
  > >
  > > +1, good idea!
  >
  >
  > or we can remove it completely
  >  it looks strange no one doing it except kde
  >  what do u think
  >  mac windows gnome cinnamon mate budgie
  >  xfce lxqt
  >  we can make this tools show with shortucut like
  >  ctrl+ mouse click on the desktop for example
  >  i think without it the desktop will look much simple and clean
  
  
  I'm mostly for removing it. A common question new users ask is how to remove 
it.
  However, the way we expose desktop widget controls is not the most intuitive 
or ergonomic for mouse & keyboard users. Long click is a mobile thing that 
isn't intuitive in the first place. We need a way to quickly expose the 
controls for desktop widgets in a way that is fairly discoverable. This is off 
topic though and this discussion should probably happen somewhere more 
permanent like a task.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: Codezela, GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

[Hazem Salem]

Codezela added a comment.


  In D18546#400256 , @GB_2 wrote:
  
  > In D18546#400253 , @hein wrote:
  >
  > > How about we actually rename it "Desktop Menu".
  >
  >
  > +1, good idea!
  
  
  or we can remove it completely
  it looks strange no one doing it except kde
  what do u think

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: Codezela, GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

[Björn Feber]

GB_2 added a comment.


  In D18546#400253 , @hein wrote:
  
  > How about we actually rename it "Desktop Menu".
  
  
  +1, good idea!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

[Eike Hein]

hein added a comment.


  How about we actually rename it "Desktop Menu".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: hein, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

[Noah Davis]

ndavis added a comment.


  I'm not sure if the `tools` icon is actually appropriate here. I know it's 
called the Desktop Toolbox, but it doesn't work at all like the tools menus in 
Spectacle or KSysGuard. It's almost like a button to open the desktop context 
menu, except it also shows the controls for widgets. It doesn't seem like a 
menu for a set of tools.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  We have a toolbox icon now, which seems like the perfect thing for something 
called the "Desktop Toolbox"

TEST PLAN
  In the corner:
  
  On the top:
  
  On its side:

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-tools-icon-for-toolbox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18546

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart